Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Export ID on Taxonomy #34143

Merged
merged 9 commits into from
Feb 8, 2024
Merged

feat: Export ID on Taxonomy #34143

merged 9 commits into from
Feb 8, 2024

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Jan 30, 2024 •
edited
Loading

Description

This adds the changes to support the new export_Id field on Taxonomy.

Supporting information

Testing instructions

Other information

  • Before to merge bump openedx-learning version

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 30, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 30, 2024 •
edited
Loading

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ChrisChV ChrisChV marked this pull request as draft January 30, 2024 15:03
ChrisChV
ChrisChV commented Jan 30, 2024
View reviewed changes
requirements/edx/kernel.in Outdated
@@ -117,7 +117,7 @@ openedx-calc # Library supporting mathematical calculatio
openedx-django-require
openedx-events # Open edX Events from Hooks Extension Framework (OEP-50)
openedx-filters # Open edX Filters from Hooks Extension Framework (OEP-50)
openedx-learning # Open edX Learning core (experimental)
git+https://github.com/open-craft/openedx-learning.git@chris/FAL-3620-export-id-on-taxonomies#egg=openedx-learning # Open edX Learning core (experimental)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Bump version with openedx/openedx-learning#145

@ChrisChV ChrisChV force-pushed the chris/FAL-3620-export-id-on-taxonomy branch 2 times, most recently from 3a1fa92 to bb1d9c4 Compare January 30, 2024 17:09
This was referenced Jan 30, 2024
Closed
Merged
@ChrisChV ChrisChV marked this pull request as ready for review January 31, 2024 17:17
@pomegranited pomegranited mentioned this pull request Feb 1, 2024
Merged
pomegranited
pomegranited approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV One nit, but 👍 once that's addressed.

  • I tested this using the PR test instructions
  • I read through the code
  • I checked for accessibility issues by using my keyboard only during testing.
  • Includes documentation
  • User-facing strings are extracted for translation N/A

openedx/core/djangoapps/content_tagging/rest_api/v1/tests/test_views.py Outdated
@@ -174,19 +176,35 @@ def _setUp_taxonomies(self):
Create taxonomies for testing
"""
# Orphaned taxonomy
self.ot1 = Taxonomy.objects.create(name="ot1", enabled=True)
self.ot2 = Taxonomy.objects.create(name="ot2", enabled=False)
self.ot1 = Taxonomy.objects.create(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use the create_taxonomy API method to create these taxonomies?

@bradenmacdonald
Copy link
Contributor

Looks fine so far. I can approve and merge next week if the openedx-learning one is merged tomorrow.

@yusuf-musleh yusuf-musleh mentioned this pull request Feb 5, 2024
Merged
@pomegranited pomegranited mentioned this pull request Feb 8, 2024
Closed
@bradenmacdonald bradenmacdonald merged commit e22b938 into openedx:master Feb 8, 2024
46 checks passed
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@xitij2000 xitij2000 deleted the chris/FAL-3620-export-id-on-taxonomy branch February 9, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomegranited pomegranited pomegranited approved these changes

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChrisChV @openedx-webhooks @bradenmacdonald @edx-pipeline-bot @pomegranited