Skip to content

Commit

Permalink
test: Fixing tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@ChrisChV
ChrisChV committed Jan 30, 2024
1 parent 313122a commit bb1d9c4
Showing 1 changed file with 111 additions and 15 deletions.
126 changes: 111 additions & 15 deletions openedx/core/djangoapps/content_tagging/rest_api/v1/tests/test_views.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -174,19 +174,35 @@ def _setUp_taxonomies(self):
Create taxonomies for testing
"""
# Orphaned taxonomy
self.ot1 = Taxonomy.objects.create(name="ot1", enabled=True)
self.ot2 = Taxonomy.objects.create(name="ot2", enabled=False)
self.ot1 = Taxonomy.objects.create(
name="ot1",
enabled=True,
export_id="ot1",
)
self.ot2 = Taxonomy.objects.create(
name="ot2",
enabled=False,
export_id="ot2",
)

# System defined taxonomy
self.st1 = Taxonomy.objects.create(name="st1", enabled=True)
self.st1 = Taxonomy.objects.create(
name="st1",
enabled=True,
export_id="st1",
)
self.st1.taxonomy_class = SystemDefinedTaxonomy
self.st1.save()
TaxonomyOrg.objects.create(
taxonomy=self.st1,
rel_type=TaxonomyOrg.RelType.OWNER,
org=None,
)
self.st2 = Taxonomy.objects.create(name="st2", enabled=False)
self.st2 = Taxonomy.objects.create(
name="st2",
enabled=False,
export_id="st2",
)
self.st2.taxonomy_class = SystemDefinedTaxonomy
self.st2.save()
TaxonomyOrg.objects.create(
Expand All @@ -195,12 +211,20 @@ def _setUp_taxonomies(self):
)

# Global taxonomy, which contains tags
self.t1 = Taxonomy.objects.create(name="t1", enabled=True)
self.t1 = Taxonomy.objects.create(
name="t1",
enabled=True,
export_id="t1",
)
TaxonomyOrg.objects.create(
taxonomy=self.t1,
rel_type=TaxonomyOrg.RelType.OWNER,
)
self.t2 = Taxonomy.objects.create(name="t2", enabled=False)
self.t2 = Taxonomy.objects.create(
name="t2",
enabled=False,
export_id="t2",
)
TaxonomyOrg.objects.create(
taxonomy=self.t2,
rel_type=TaxonomyOrg.RelType.OWNER,
Expand All @@ -213,33 +237,53 @@ def _setUp_taxonomies(self):
Tag.objects.create(taxonomy=self.t1, value="anvil", parent=root1)

# OrgA taxonomy
self.tA1 = Taxonomy.objects.create(name="tA1", enabled=True)
self.tA1 = Taxonomy.objects.create(
name="tA1",
enabled=True,
export_id="tA1",
)
TaxonomyOrg.objects.create(
taxonomy=self.tA1,
org=self.orgA, rel_type=TaxonomyOrg.RelType.OWNER,)
self.tA2 = Taxonomy.objects.create(name="tA2", enabled=False)
self.tA2 = Taxonomy.objects.create(
name="tA2",
enabled=False,
export_id="tA2",
)
TaxonomyOrg.objects.create(
taxonomy=self.tA2,
org=self.orgA,
rel_type=TaxonomyOrg.RelType.OWNER,
)

# OrgB taxonomy
self.tB1 = Taxonomy.objects.create(name="tB1", enabled=True)
self.tB1 = Taxonomy.objects.create(
name="tB1",
enabled=True,
export_id="tB1",
)
TaxonomyOrg.objects.create(
taxonomy=self.tB1,
org=self.orgB,
rel_type=TaxonomyOrg.RelType.OWNER,
)
self.tB2 = Taxonomy.objects.create(name="tB2", enabled=False)
self.tB2 = Taxonomy.objects.create(
name="tB2",
enabled=False,
export_id="tB2",
)
TaxonomyOrg.objects.create(
taxonomy=self.tB2,
org=self.orgB,
rel_type=TaxonomyOrg.RelType.OWNER,
)

# OrgA and OrgB taxonomy
self.tBA1 = Taxonomy.objects.create(name="tBA1", enabled=True)
self.tBA1 = Taxonomy.objects.create(
name="tBA1",
enabled=True,
export_id="tBA1",
)
TaxonomyOrg.objects.create(
taxonomy=self.tBA1,
org=self.orgA,
Expand All @@ -250,7 +294,11 @@ def _setUp_taxonomies(self):
org=self.orgB,
rel_type=TaxonomyOrg.RelType.OWNER,
)
self.tBA2 = Taxonomy.objects.create(name="tBA2", enabled=False)
self.tBA2 = Taxonomy.objects.create(
name="tBA2",
enabled=False,
export_id="tBA2",
)
TaxonomyOrg.objects.create(
taxonomy=self.tBA2,
org=self.orgA,
Expand Down Expand Up @@ -466,6 +514,7 @@ def test_create_taxonomy(self, user_attr: str, expected_status: int) -> None:
"description": "This is a description",
"enabled": True,
"allow_multiple": True,
"export_id": "taxonomy_data",
}

if user_attr:
Expand Down Expand Up @@ -1327,16 +1376,28 @@ def setUp(self):
block_id='block_id'
)

self.multiple_taxonomy = Taxonomy.objects.create(name="Multiple Taxonomy", allow_multiple=True)
self.single_value_taxonomy = Taxonomy.objects.create(name="Required Taxonomy", allow_multiple=False)
self.multiple_taxonomy = Taxonomy.objects.create(
name="Multiple Taxonomy",
allow_multiple=True,
export_id="multiple_taxonomy",
)
self.single_value_taxonomy = Taxonomy.objects.create(
name="Required Taxonomy",
allow_multiple=False,
export_id="required_taxonomy",
)
for i in range(20):
# Valid ObjectTags
Tag.objects.create(taxonomy=self.tA1, value=f"Tag {i}")
Tag.objects.create(taxonomy=self.tA2, value=f"Tag {i}")
Tag.objects.create(taxonomy=self.multiple_taxonomy, value=f"Tag {i}")
Tag.objects.create(taxonomy=self.single_value_taxonomy, value=f"Tag {i}")

self.open_taxonomy = Taxonomy.objects.create(name="Enabled Free-Text Taxonomy", allow_free_text=True)
self.open_taxonomy = Taxonomy.objects.create(
name="Enabled Free-Text Taxonomy",
allow_free_text=True,
export_id="enabled_free_text_taxonomy",
)

# Add org permissions to taxonomy
TaxonomyOrg.objects.create(
Expand Down Expand Up @@ -1701,6 +1762,7 @@ def test_import_global_admin(self, file_format: str) -> None:
{
"taxonomy_name": "Imported Taxonomy name",
"taxonomy_description": "Imported Taxonomy description",
"taxonomy_export_id": "imported_taxonomy",
"file": file,
},
format="multipart"
Expand All @@ -1711,6 +1773,7 @@ def test_import_global_admin(self, file_format: str) -> None:
taxonomy = response.data
assert taxonomy["name"] == "Imported Taxonomy name"
assert taxonomy["description"] == "Imported Taxonomy description"
assert taxonomy["export_id"] == "imported_taxonomy"

# Check if the tags were created
url = TAXONOMY_TAGS_URL.format(pk=taxonomy["id"])
Expand Down Expand Up @@ -1746,6 +1809,7 @@ def test_import_orgA_admin(self, file_format: str) -> None:
{
"taxonomy_name": "Imported Taxonomy name",
"taxonomy_description": "Imported Taxonomy description",
"taxonomy_export_id": "imported_taxonomy",
"file": file,
},
format="multipart"
Expand All @@ -1756,6 +1820,7 @@ def test_import_orgA_admin(self, file_format: str) -> None:
taxonomy = response.data
assert taxonomy["name"] == "Imported Taxonomy name"
assert taxonomy["description"] == "Imported Taxonomy description"
assert taxonomy["export_id"] == "imported_taxonomy"

# Check if the tags were created
url = TAXONOMY_TAGS_URL.format(pk=taxonomy["id"])
Expand All @@ -1780,6 +1845,7 @@ def test_import_no_file(self) -> None:
{
"taxonomy_name": "Imported Taxonomy name",
"taxonomy_description": "Imported Taxonomy description",
"taxonomy_export_id": "imported_taxonomy",
},
format="multipart"
)
Expand All @@ -1804,6 +1870,7 @@ def test_import_no_name(self, file_format) -> None:
url,
{
"taxonomy_description": "Imported Taxonomy description",
"taxonomy_export_id": "imported_taxonomy",
"file": file,
},
format="multipart"
Expand All @@ -1814,6 +1881,29 @@ def test_import_no_name(self, file_format) -> None:
# Check if the taxonomy was not created
assert not Taxonomy.objects.filter(name="Imported Taxonomy name").exists()

@ddt.data(
"csv",
"json",
)
def test_import_no_export_id(self, file_format) -> None:
url = TAXONOMY_CREATE_IMPORT_URL
file = SimpleUploadedFile(f"taxonomy.{file_format}", b"invalid file content")
self.client.force_authenticate(user=self.staff)
response = self.client.post(
url,
{
"taxonomt_name": "Imported Taxonomy name",
"taxonomy_description": "Imported Taxonomy description",
"file": file,
},
format="multipart"
)
assert response.status_code == status.HTTP_400_BAD_REQUEST
assert response.data["taxonomy_export_id"][0] == "This field is required."

# Check if the taxonomy was not created
assert not Taxonomy.objects.filter(name="Imported Taxonomy name").exists()

def test_import_invalid_format(self) -> None:
"""
Tests importing a taxonomy with an invalid file format.
Expand All @@ -1826,6 +1916,7 @@ def test_import_invalid_format(self) -> None:
{
"taxonomy_name": "Imported Taxonomy name",
"taxonomy_description": "Imported Taxonomy description",
"taxonomy_export_id": "imported_taxonomy_id",
"file": file,
},
format="multipart"
Expand All @@ -1852,6 +1943,7 @@ def test_import_invalid_content(self, file_format) -> None:
{
"taxonomy_name": "Imported Taxonomy name",
"taxonomy_description": "Imported Taxonomy description",
"taxonomy_export_id": "imported_taxonomy",
"file": file,
},
format="multipart"
Expand Down Expand Up @@ -1881,6 +1973,7 @@ def test_import_no_perm(self) -> None:
{
"taxonomy_name": "Imported Taxonomy name",
"taxonomy_description": "Imported Taxonomy description",
"taxonomy_export_id": "imported_taxonomy",
"file": file,
},
format="multipart"
Expand All @@ -1902,6 +1995,7 @@ def setUp(self):

self.taxonomy = Taxonomy.objects.create(
name="Test import taxonomy",
export_id="test_import_taxonomy",
)
tag_1 = Tag.objects.create(
taxonomy=self.taxonomy,
Expand Down Expand Up @@ -2009,6 +2103,7 @@ def test_import_invalid_content(self, file_format) -> None:
{
"taxonomy_name": "Imported Taxonomy name",
"taxonomy_description": "Imported Taxonomy description",
"taxonomy_export_id": "imported_taxonomy",
"file": file,
},
format="multipart"
Expand Down Expand Up @@ -2078,6 +2173,7 @@ def test_import_no_perm(self) -> None:
{
"taxonomy_name": "Imported Taxonomy name",
"taxonomy_description": "Imported Taxonomy description",
"taxonomt_export_id": "imported_taxonomy",
"file": file,
},
format="multipart"
Expand Down

0 comments on commit bb1d9c4

Please sign in to comment.