Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated receiver/scraperhelper package #12054

Merged
merged 10 commits into from
Jan 9, 2025

Conversation

sincejune
Copy link
Contributor

@sincejune sincejune commented Jan 8, 2025

Description

Removing the deprecated receiver/scraperhelper package

Link to tracking issue

blocked by #12055

Testing

n/a

Documentation

Added

@sincejune sincejune requested a review from a team as a code owner January 8, 2025 09:20
@sincejune sincejune requested a review from dmitryax January 8, 2025 09:20
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.67%. Comparing base (0ece678) to head (1f3a113).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12054   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         455      455           
  Lines       24038    24038           
=======================================
  Hits        22037    22037           
  Misses       1629     1629           
  Partials      372      372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu enabled auto-merge January 8, 2025 17:05
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment, since the deprecated types are being removed, it should be documented as a breaking change

auto-merge was automatically disabled January 8, 2025 18:26

Head branch was pushed to by a user without write access

@mx-psi mx-psi added this pull request to the merge queue Jan 9, 2025
Merged via the queue into open-telemetry:main with commit 3132112 Jan 9, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants