-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Support logs in scrapercontroller #12056
[chore] Support logs in scrapercontroller #12056
Conversation
dc55506
to
2c99924
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12056 +/- ##
==========================================
- Coverage 91.68% 91.67% -0.01%
==========================================
Files 455 455
Lines 24039 24109 +70
==========================================
+ Hits 22039 22101 +62
- Misses 1629 1634 +5
- Partials 371 374 +3 ☔ View full report in Codecov by Sentry. |
96ebdee
to
ac90903
Compare
Please rebase. I think you will no longer need |
Closing this in favor of #12116 cc @bogdandrutu |
Description
This PR added support for logs in
scraper/scrapercontroller
:controller
for logs.AddScraper
toAddMetricsScraper
cuz it receives ascraper.Metrics
as input.NewScraperControllerReceiver
toNewMetricsScraperControllerReceiver
cuz it receives aconsumer.Metrics
as input.Note:
receiver/scraperhelper/idias
, will rebase once that's merged.newObsLogs
, will rebase once that's merged.Add @bogdandrutu to this thread as well.
Link to tracking issue
Relevant to #12038
Testing
Added
Documentation
n/a. Adding
[chore]
to this PR cuz this is only the first part of the change.