Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed SecurityConfiguration #3

Merged
merged 2 commits into from
Nov 22, 2019
Merged

removed SecurityConfiguration #3

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7d42fc
removed SecurityConfiguration
moksamedia Nov 21, 2019
747f0a9
Merge branch 'master' into master
Nov 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webflux-oauth2login/src/main/java/com/okta/webflux/app/ReactiveApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.okta.webflux.App;
package com.okta.webflux.app;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
Expand Down
2 changes: 1 addition & 1 deletion webflux-oauth2login/src/main/java/com/okta/webflux/app/ReactiveHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.okta.webflux.App;
package com.okta.webflux.app;

import org.springframework.http.MediaType;
import org.springframework.stereotype.Component;
Expand Down
2 changes: 1 addition & 1 deletion webflux-oauth2login/src/main/java/com/okta/webflux/app/ReactiveRouter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.okta.webflux.App;
package com.okta.webflux.app;

import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
Expand Down
23 changes: 0 additions & 23 deletions webflux-oauth2login/src/main/java/com/okta/webflux/app/SecurityConfiguration.java
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions webflux-oauth2login/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
okta.oauth2.issuer=https://dev-820159.okta.com/oauth2/default
okta.oauth2.clientId=0oa1ec63zpvcYtLGj357
okta.oauth2.clientSecret=qwmW0BXLlqWwPdrwOKHNigNGbM21whD3wjOaOucU
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moksamedia Why did you remove the client secret? Was that intentional?

I know Spring Security 5.2 added support for PKCE, which makes it possible to do auth code flow without a secret. However, it doesn't work with our starter when I last tried it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be working for me without it. That's why I removed it. I just double-checked it. Can you try it to verify?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remove it and try locally, I get a 401 in the browser instead of a redirect. I'll add it back in.

Screen Shot 2019-11-22 at 11 56 14 AM

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops. Sorry. I tested it as a resource server, not as OAuth2 Login. Written too many of the resource server tutorials.

okta.oauth2.issuer={yourIssuerUri}
okta.oauth2.clientId={yourClientId}