removed SecurityConfiguration #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraible
suggested changes
Nov 21, 2019
| @@ -1,3 +1,2 @@ | |||
| okta.oauth2.issuer=https://dev-820159.okta.com/oauth2/default | |||
| okta.oauth2.clientId=0oa1ec63zpvcYtLGj357 | |||
| okta.oauth2.clientSecret=qwmW0BXLlqWwPdrwOKHNigNGbM21whD3wjOaOucU | |||
There was a problem hiding this comment.
@moksamedia Why did you remove the client secret? Was that intentional?
I know Spring Security 5.2 added support for PKCE, which makes it possible to do auth code flow without a secret. However, it doesn't work with our starter when I last tried it.
There was a problem hiding this comment.
It seems to be working for me without it. That's why I removed it. I just double-checked it. Can you try it to verify?
There was a problem hiding this comment.
If I remove it and try locally, I get a 401 in the browser instead of a redirect. I'll add it back in.
There was a problem hiding this comment.
Ooops. Sorry. I tested it as a resource server, not as OAuth2 Login. Written too many of the resource server tutorials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the SecurityConfiguration.java file, also lower cased the package name.