Added PR template file in github. and added PR Template section in contributions.md file #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabine
reviewed
Jan 6, 2025
CONTRIBUTING.md
Outdated
| @@ -28,6 +28,7 @@ We've provided a list of community-driven content below. When adding content to | |||
| - [Recurring Events](#content-recurring-event) | |||
| - [Upcoming Events](#content-upcoming_event) | |||
| - [The OCaml Changelog](#content-changelog) | |||
| - [PR Template](#content-cookbook) | |||
There was a problem hiding this comment.
I would recommend to put this under the existing "OCaml Cookbook Recipes" section, not as a separate section.
Overall looks useful to me. 👍
|
Sure I'll do the changes by noon.
…On Tue, 7 Jan, 2025, 3:12 am sabine, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CONTRIBUTING.md
<#2907 (comment)>:
> @@ -28,6 +28,7 @@ We've provided a list of community-driven content below. When adding content to
- [Recurring Events](#content-recurring-event)
- [Upcoming Events](#content-upcoming_event)
- [The OCaml Changelog](#content-changelog)
+- [PR Template](#content-cookbook)
I would recommend to put this under the existing "OCaml Cookbook Recipes"
section, not as a separate section.
Overall looks useful to me. 👍
—
Reply to this email directly, view it on GitHub
<#2907 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A75YSI43OX3O44NMBCL62R32JL2ELAVCNFSM6AAAAABUWJERJOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZTGAZDENJSGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Added Guidelines for New Recipes.
|
Hello @sabine I made the changes could you please review it? |
|
@sabine could you please review! |
sabine
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Thanks @labdhiongithub7, I rearranged a little and created another PR template for non-cookbook PRs, and a template to select between them. Merging now! ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.