Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Pull Request Template for contributions to the OCaml Cookbook and update CONTRIBUTING.md #2904

Closed
sabine opened this issue Jan 3, 2025 · 4 comments
Assignees

Comments

@sabine
Copy link
Collaborator

sabine commented Jan 3, 2025

To simplify people self-reviewing their submissions, we need a checklist in a PR Template to communicate the guidelines for new cookbook recipes, especially on whether a new task is admissible.

At the same time, these guidelines need to be added to CONTRIBUTING.md.

Guidelines from https://discuss.ocaml.org/t/feedback-help-wanted-upcoming-ocaml-org-cookbook-feature/14127/37?u=sabine

@labdhiongithub7
Copy link
Contributor

@sabine I would like to do this task.

@sabine
Copy link
Collaborator Author

sabine commented Jan 6, 2025

@labdhiongithub7 thanks for offering, would be glad if you can prepare a PR template!

@labdhiongithub7
Copy link
Contributor

Hi @sabine, could you please review #2907 and let me know if any updates are needed?
Thanks!!

@sabine
Copy link
Collaborator Author

sabine commented Jan 24, 2025

Thanks @labdhiongithub7, I merged it.

@sabine sabine closed this as completed Jan 24, 2025
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in OCaml.org Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants