Feature/aut 3965/enable vertical writing #4168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
olga-kulish
force-pushed
the
feature/AUT-3965/enable-vertical-writing
branch
from
770cc60 to
d9e9888
Compare
1 task
olga-kulish
commented
Jan 16, 2025
wazelin
requested changes
Jan 23, 2025
poyuki
approved these changes
Jan 23, 2025
wazelin
reviewed
Jan 23, 2025
wazelin
reviewed
Jan 24, 2025
Version
There are 0 BREAKING CHANGE, 1 feature, 2 fixes |
wazelin
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://oat-sa.atlassian.net/browse/AUT-3965
Add
VerticalWritingModeproperty for Japanese language, for FE to use it with/tao/Languages/indexendpoint.Possible values: not set,
vertical-rl[Chinese, Korean, Japanese],vertical-lr[Mongolian].If you think it's an unnecessary complication, we can just hardcode list of languages on FE, no problem.
FE part: oat-sa/extension-tao-itemqti#2661
Deployed to unit01