Feature/aut 3965/enable vertical writing #2661
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
olga-kulish
commented
Jan 14, 2025
Version
There are 0 BREAKING CHANGE, 1 feature, 0 fix |
oatymart
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Verified on unit01.
Works as expected, and sets the desired class for the vertical languages.
Use of the existing BE request is efficient.
I didn't check too deeply the backend code but it seems a straightforward change.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
-
Feature is working correctly on my local machine (if applicable) - Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master(ormain) - or is a release - Bundled code is present if needed
-
Version bump is applied if needed (packages AND root) - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
-
Changelog is updated according to changes (if applicable) - Documentation is updated according to changes (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://oat-sa.atlassian.net/browse/AUT-3965
Allows to enable "Vertical writing" for Japanese language.
How it's applied in deliver-fe: https://github.com/oat-sa/tao-deliver-fe/pull/1352
composer.jsondependency version before merge.Deployed to unit01