chore: fix performance downgrade by reverting code to previous #2565
+4
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version
There are 0 BREAKING CHANGE, 0 feature, 0 fix |
Front-end summary Node 18
|
bartlomiejmarszal
approved these changes
Jan 10, 2025
shpran
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket: https://oat-sa.atlassian.net/browse/LSI-5144
this PR aims to revert the code introduced in #2383 which causes performance drop.
Unfortunately, this fix cannot be directly tested in terms of situation where performance drop has happened. In situations different from benchmark or real campaign, meaning without quite heavy load, - it would just work not causing and not solving anything.
Grafana access would be shared via Keeper.
Grafana board with the benchmark attempt using the less-performant code: link. As it may fail because of the time zones, the time range is 2024-12-26 14:17:30 CET to 2024-12-26 14:34:30. Benchmarking attempt was cancelled, when CPU usage went over 90%.
Grafana board with the benchmark attempt, reverting the less-performant code: link. As it may fail because of the time zones, the time range is 2024-12-27 11:56:30 CET to 2024-12-27 12:38:30. Benchmarking attempt was finished not going higher than 66% CPU.