fix: avoid looping through each service when the service ID is missing from the PSR container and has to be loaded via ServiceManager #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wazelin
requested review from
gabrielfs7,
uncleempty,
pedromarceOAT and
augustas
tikhanovichA
approved these changes
Jan 13, 2025
bartlomiejmarszal
approved these changes
Jan 13, 2025
…g from the PSR container and has to be loaded via ServiceManager
wazelin
force-pushed
the
fix/LSI-5144/avoid-looping-through-each-service
branch
from
0a12247 to
a3ec73a
Compare
Version
There are 0 BREAKING CHANGE, 0 feature, 1 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSI-5144
This PR is inspired by the problem described in oat-sa/extension-tao-testqti#2565.
The PR avoids multiple long loops through each service when the service ID provided is missing from the PSR container and has to be loaded via the ServiceManager.
See https://github.com/symfony/dependency-injection/blob/5.4/Container.php#L262-L270.
I expect this PR to give TAO 3.x a measurable performance boost.