feature: add new event ResultTestVariablesAfterTransmissionEvent #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2425 +/- ##
=============================================
- Coverage 16.94% 16.88% -0.06%
- Complexity 3203 3222 +19
=============================================
Files 208 209 +1
Lines 11542 11594 +52
=============================================
+ Hits 1956 1958 +2
- Misses 9586 9636 +50 ☔ View full report in Codecov by Sentry. |
pribi
reviewed
Dec 6, 2023
pribi
reviewed
Dec 6, 2023
|
Can you please add test coverage to the new code created? |
Front-end summary Node 18
|
pnal
requested changes
Dec 7, 2023
…ssionEventHandler
pnal
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
models/classes/eventHandler/ResultTransmissionEventHandler/ResultTransmissionEventHandler.php
Outdated
Show resolved
Hide resolved
models/classes/eventHandler/ResultTransmissionEventHandler/ResultTransmissionEventHandler.php
Show resolved
Hide resolved
Version
There are 0 BREAKING CHANGE, 3 features, 4 fixes |
andreluizmachado
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
Karol-Stelmaczonek
added a commit
that referenced
this pull request
Dec 13, 2023
* feature: add new event ResultTestVariablesAfterTransmissionEvent * feature: rewrite LtiAgsListener * fix: codestyle * fix: codestyle * fix: code review * feature: change to TestVariablesRecorded, and use it in ResultTransmissionEventHandler * fix: code review fixes (cherry picked from commit e67ac34)
Karol-Stelmaczonek
added a commit
that referenced
this pull request
Dec 13, 2023
feature: add new event ResultTestVariablesAfterTransmissionEvent (#2425)
Karol-Stelmaczonek
added a commit
that referenced
this pull request
Dec 15, 2023
* feature: add new event ResultTestVariablesAfterTransmissionEvent * feature: rewrite LtiAgsListener * fix: codestyle * fix: codestyle * fix: code review * feature: change to TestVariablesRecorded, and use it in ResultTransmissionEventHandler * fix: code review fixes (cherry picked from commit e67ac34)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://oat-sa.atlassian.net/browse/INF-235
What's Changed
Screenshare.-.2023-12-06.10_31_04.AM.mp4