Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add new event ResultTestVariablesAfterTransmissionEvent (#2425) #2429

Merged
merged 1 commit into from
Dec 13, 2023
Merged

feature: add new event ResultTestVariablesAfterTransmissionEvent (#2425) #2429

merged 1 commit into from
Dec 13, 2023

Conversation

Karol-Stelmaczonek
Copy link
Contributor

@Karol-Stelmaczonek Karol-Stelmaczonek commented Dec 13, 2023 •
edited
Loading

Backport of #2425

  • feature: add new event ResultTestVariablesAfterTransmissionEvent

  • feature: rewrite LtiAgsListener

  • fix: codestyle

  • fix: codestyle

  • fix: code review

  • feature: change to TestVariablesRecorded, and use it in ResultTransmissionEventHandler

  • fix: code review fixes

(cherry picked from commit e67ac34)

@Karol-Stelmaczonek
feature: add new event ResultTestVariablesAfterTransmissionEvent (#2425)
06b04ec 
* feature: add new event ResultTestVariablesAfterTransmissionEvent

* feature: rewrite LtiAgsListener

* fix: codestyle

* fix: codestyle

* fix: code review

* feature: change to TestVariablesRecorded, and use it in ResultTransmissionEventHandler

* fix: code review fixes

(cherry picked from commit e67ac34)
pnal
pnal approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@pnal pnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the same commit cherry picked

andreluizmachado
andreluizmachado approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@andreluizmachado andreluizmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Karol-Stelmaczonek Karol-Stelmaczonek merged commit 006e6e0 into release-45.0.3.1 Dec 13, 2023
@Karol-Stelmaczonek Karol-Stelmaczonek mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnal pnal pnal approved these changes

@andreluizmachado andreluizmachado andreluizmachado approved these changes

@pribi pribi Awaiting requested review from pribi

@bartlomiejmarszal bartlomiejmarszal Awaiting requested review from bartlomiejmarszal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Karol-Stelmaczonek @andreluizmachado @pnal