update signature for hash_foreach value #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
Sep 12, 2024
sdk/ext/ovirtsdk4c/ov_http_client.c
Outdated
| @@ -490,12 +493,20 @@ static int ov_http_client_debug_function(CURL* handle, curl_infotype type, char* | |||
| /* Get the pointer to the transfer: */ | |||
| ov_http_transfer_ptr(transfer, transfer_ptr); | |||
|
|
|||
| /* Execute the debug code with the global interpreter lock acquired, as it needs to call Ruby methods: */ | |||
| /* The global interpreter lock may be acquired or not, so we need to check and either call the task directly | |||
| or else call it after acquiring the lock. Note that the `ruby_thread_has_gvl_p` function that we ue to | |||
There was a problem hiding this comment.
Suggested change
| or else call it after acquiring the lock. Note that the `ruby_thread_has_gvl_p` function that we ue to | |
| or else call it after acquiring the lock. Note that the `ruby_thread_has_gvl_p` function that we use to |
There was a problem hiding this comment.
ooh, I see this commit in the other PR, will bring it across
I will pull from #10 but I see that it is not signed off
Open
|
I can pull just my own commits out into a separate PR (since it is signed off) if you would like. |
Thanks for handling this. Please feel free to use that patch. It'll be great if the fix is merged upstream. |
The C code needs to be udpated to use the `rb_thread_call_with_gvl` only when the code doesn't already hold the GVL. This is probably due to changes in `libcurl`. Signed-off-by: Juan Hernandez <[email protected]>
Thanks Co-authored-by: eremeyev <[email protected]>
Signed-off-by: Keenan Brock <[email protected]>
This can be found https://github.com/ruby/ruby/blob/5d358b660d41e64de301f428dc0300a52a6f9566/internal/thread.h#L77 All users of this method seem to just declare the method up front, as access to ruby's internal headers are discouraged Signed-off-by: Keenan Brock <[email protected]>
sandrobonazzola
force-pushed
the
fix_pointer
branch
from
9abf9d7 to
9788b02
Compare
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves one issue in #14
Change
Updated c files to fix warnings (that prevent this from building on a mac and linux machine)
Before
After
(hopefully. I can't do this since I can't push the changes)
@sunpoet This is your code change from freebsd. If this gets merged, you will be able to remove it from your custom patch. Is it ok to apply here? Thnx
If you want me to add attribution and signoff for you, or if you'd prefer creating your own PR. Please let me know.
UPDATE: contact with author and signed off
--
@jhernand I pulled out your c change from #10 - I feel the
gemspecchanges are probably also needed, but trying to keep this as minimal as possible.I left your signoff for the partial commit, please let me know if you agree or feel this does not properly reflect your intent.
@sandrobonazzola I noticed your commit does not have a Signoff. Please advise