Update to Ruby 3 #10
Update to Ruby 3 #10
Conversation
|
Not that this will also need a new version of the API metamodel containing this change: oVirt/ovirt-engine-api-metamodel#34 |
sandrobonazzola
force-pushed
the
update_to_ruby_3
branch
from
3c2faa8 to
9f218e8
Compare
|
Would it be easier to merge if we split this PR apart? Or is the issue that there just isn't much time and multiple PRs are actually more difficult? |
|
I pulled the c code fix and put into #17 (kept attribution) |
|
@sandrobonazzola FYI - your commit does not have signoff |
I just hit rebase :-) |
Currently the SDK doesn't build or work with Ruby 3: - The code generator needs at least Weld 3 in order to work with Java 11. - The versions of `rake`, `rubocop` and `webrick` need to be udpated to work with Ruby 3. - The C code needs to be udpated to use the `rb_thread_call_with_gvl` only when the code doesn't already hold the GVL. This is probably due to changes in `libcurl`. This patch contains fixes for all those issues. Signed-off-by: Juan Hernandez <[email protected]>
Thanks Co-authored-by: eremeyev <[email protected]>
sandrobonazzola
force-pushed
the
update_to_ruby_3
branch
from
9f218e8 to
957fb6f
Compare
sandrobonazzola
requested review from
mwperina and
a team
and removed request for
eremeyev
|
The problem with this change is, that weld 3 super hard to package as RPM due to missing dependencies, that's why we are still using weld 2.y. If we merge this PR before weld 3.y is available as RPM on cbs.centos.org, build process will be completely broken: |
| @@ -66,8 +66,8 @@ limitations under the License. | |||
| <!-- The generator runs in a CDI environment, implemented by Weld: --> | |||
| <dependency> | |||
| <groupId>org.jboss.weld.se</groupId> | |||
| <artifactId>weld-se</artifactId> | |||
| <version>2.3.0.Final</version> | |||
| <artifactId>weld-se-core</artifactId> | |||
There was a problem hiding this comment.
Can we change to weld-se-shaded?
Currently the SDK doesn't build or work with Ruby 3:
The code generator needs at least Weld 3 in order to work with Java 11.
The versions of
rake,rubocopandwebrickneed to be udpated to work with Ruby 3.The C code needs to be udpated to use the
rb_thread_call_with_gvlonly when the code doesn't already hold the GVL. This is probably due to changes inlibcurl.This patch contains fixes for all those issues.