Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup in campaigns app #5779

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Cleanup in campaigns app #5779

merged 6 commits into from
Jan 14, 2025

Conversation

rowanseymour
Copy link
Member

@rowanseymour rowanseymour commented Jan 9, 2025

  • Remove viewer users from perms and tests
  • Move remaining web tests into CampaignCRUDLTest and CampaignEventCRUDLTest
  • Simplify how event create view references the campaign

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (47866ca) to head (3c75cf7).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5779   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          454       454           
  Lines        25080     25080           
=========================================
  Hits         25080     25080           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour changed the title Remove viewer access for some apps Cleanup in campaigns app Jan 14, 2025
@rowanseymour rowanseymour marked this pull request as ready for review January 14, 2025 21:44
@rowanseymour rowanseymour merged commit 518a8cc into main Jan 14, 2025
5 checks passed
@rowanseymour rowanseymour deleted the remove_viewers_pt3 branch January 14, 2025 22:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant