Merge pull request #5779 from nyaruka/remove_viewers_pt3

Cleanup in campaigns app
nyaruka · Jan 14, 2025 · 518a8cc · 518a8cc
2 parents 47866ca + 3c75cf7
commit 518a8cc
Show file tree

Hide file tree

Showing 8 changed files with 179 additions and 572 deletions.
diff --git a/temba/api/v2/tests/test_campaign_events.py b/temba/api/v2/tests/test_campaign_events.py
@@ -15,8 +15,8 @@ def test_endpoint(self, mr_mocks):
         endpoint_url = reverse("api.v2.campaign_events") + ".json"
 
         self.assertGetNotPermitted(endpoint_url, [None, self.agent])
-        self.assertPostNotPermitted(endpoint_url, [None, self.user, self.agent])
-        self.assertDeleteNotPermitted(endpoint_url, [None, self.user, self.agent])
+        self.assertPostNotPermitted(endpoint_url, [None, self.agent])
+        self.assertDeleteNotPermitted(endpoint_url, [None, self.agent])
 
         joe = self.create_contact("Joe Blow", phone="+250788123123")
         frank = self.create_contact("Frank", urns=["facebook:123456"])
@@ -63,7 +63,7 @@ def test_endpoint(self, mr_mocks):
         # no filtering
         self.assertGet(
             endpoint_url,
-            [self.user, self.editor, self.admin],
+            [self.editor, self.admin],
             results=[
                 {
                     "uuid": str(event3.uuid),

diff --git a/temba/api/v2/tests/test_campaigns.py b/temba/api/v2/tests/test_campaigns.py
@@ -12,7 +12,7 @@ def test_endpoint(self):
         endpoint_url = reverse("api.v2.campaigns") + ".json"
 
         self.assertGetNotPermitted(endpoint_url, [None, self.agent])
-        self.assertPostNotPermitted(endpoint_url, [None, self.user, self.agent])
+        self.assertPostNotPermitted(endpoint_url, [None, self.agent])
         self.assertDeleteNotAllowed(endpoint_url)
 
         joe = self.create_contact("Joe Blow", phone="+250788123123")
@@ -29,7 +29,7 @@ def test_endpoint(self):
         # no filtering
         response = self.assertGet(
             endpoint_url,
-            [self.user, self.editor, self.admin],
+            [self.editor, self.admin],
             results=[
                 {
                     "uuid": str(campaign2.uuid),