Remove problematic euro symbol regex in fi

[WxnChen11]

Remove complexSymbol euro introduced in fi locale in e5dfd96. It is causing issues with reading of euro currency cells in microsoft Excel.

Link to issue number:

#17471

Summary of the issue:

Euro complexSymbol in fi locale causing euro currency numbers to not be read in microsoft excel.

Description of user facing changes

Affects the reading of euro currency numbers in microsoft excel. The behavior should be in line with that of some common locales such as english and spanish where this regex is not present.

Description of development approach

Followed the advice of seanbudd and removed the regex, after spot-checking to verify that this is likely a finnish-only regex and behavior.

Testing strategy:

Unit tests: It might make sense to add a unit test for the processing of euro symbols in not just finnish but all languages.. I will need a pointer to where these should go if there is a good place.
Manual testing: will require deferral to a an individual who has a working microsoft excel license or subscription.

Known issues with pull request:

Requires testing (manual, maybe unit tests)
Requires UX vetting for fi locale, to verify that euro symbols are not somehow different (?) than other languages

Code Review Checklist:

• Documentation: (Minor change, I do not think it requires a doc entry)
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons. (breaking release)
• [ ] Security precautions taken. (symbol mapping change, I would expect no significant runtime changes, but might be a good idea for someone more experienced to check this off.)

@coderabbitai summary

[josephsl]

Hi,

As this is a locale data issue, may I suggest resolving it via translations workflow instead of a direct pull request?

Thanks.

[WxnChen11]

Hi Joseph, thank you for your comment. I'm new to the project. Could you elaborate on what the translations workflow entails?

[WxnChen11]

I found https://github.com/nvaccess/nvda/wiki/TranslatingUsingAutomaticProcess, and I requested an invitation to join the group.

[josephsl]

Hi, a separate workflow (based on Subversion and Crowdin) is used to manage localization data like the change proposed in this PR> For this PR, an NVDA translator would inform the NVDA translations forum, informing people that an issue with the Finnish translation is causing an NVDA issue. The Finnish translator could then resolve the issue by fixing the localization data themselves and posting it to the translations workflow area (I believe symbols dictionary is still handled via Subversion), which will then be picked up as part of a future localization data exchange event. Thanks.

[seanbudd]

@josephsl - we are no longer using SVN. This is the correct process for updating symbols files now

[josephsl]

Hi, I see – I should revisit the documentation then (unless the translation related docs was updated). Thanks.

[seanbudd]

Could you please also send an email to the translators mailing list notifying the Finnish translators about this change.
Thanks

[WxnChen11]

Sent an email for approval by moderators.