Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbers with euro symbol are not announced when symbol level is all #17471

Closed
burmancomp opened this issue Dec 2, 2024 · 7 comments
Closed
Labels
component/i18n existing localisations or internationalisation good first issue github features these at https://github.com/nvaccess/nvda/contribute p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority quick fix triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@burmancomp
Copy link
Contributor

Steps to reproduce:

I think this could be detected also elsewhere but at least in excel:

  • open excel worksheet, format cell so that it is for currency, and set symbol to euro symbol
  • change nvda synthesizer to onecore (I have detected this firstly with Finnish SAPI5 tts mikropuhe 5.1) and symbol level to all
  • write to cell you previously formatted something like 1,23

Actual behavior:

You should hear only "euro" or similar without number when you navigate back to previously formatted cell; if not then this is Finnish related issue.

Expected behavior:

Similar to other symbol levels.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

installed

NVDA version:

alpha-34670,def6a444 (2025.1.0.34670)

Windows version:

w10 2022h2

Name and version of other software in use when reproducing the issue:

excel 2019

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

Have you tried any other versions of NVDA? If so, please report their behaviors.

If NVDA add-ons are disabled, is your problem still occurring?

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

@Adriani90
Copy link
Collaborator

I cannot reproduce it in Excel 365 with NVDA last alpha.
When symbol level is other than all, the synth speaks "one Euro and twenty three cents". When symbols level is all, the synthesizer speaks "one point twenty three euro".

I tried with eSPeak, ONecore and SAPI5.

@burmancomp
Copy link
Contributor Author

I tested with microsoft sapi5 voice david, and I cannot reproduce this. So this seems not to be issue at least with english.

@burmancomp
Copy link
Contributor Author

I can reproduce this with espeak finnish.

@burmancomp
Copy link
Contributor Author

If "trust voice's language when processing characters and symbols" is unchecked, numbers are announced but in english (I tested with finnish mikropuhe sapi5).

@seanbudd seanbudd added needs-technical-investigation A technical investigation is required to progress the issue. needs-triage labels Dec 2, 2024
@seanbudd
Copy link
Member

seanbudd commented Dec 2, 2024

Where can finnish mikropuhe sapi5 be found to reproduce this?

@seanbudd
Copy link
Member

seanbudd commented Dec 2, 2024

The cause of this is

euro ^(0|(([1-9]{1}|[1-9]{1}[0-9]{1}|[1-9]{1}[0-9]{2}){1}(\ [0-9]{3}){0,})),(([0-9]{2})|\-\-)([\ ]{1})(€){1}$
, this regex needs to be removed or fixed.

@seanbudd seanbudd added component/i18n existing localisations or internationalisation p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority quick fix good first issue github features these at https://github.com/nvaccess/nvda/contribute triaged Has been triaged, issue is waiting for implementation. and removed needs-technical-investigation A technical investigation is required to progress the issue. needs-triage labels Dec 2, 2024
@seanbudd seanbudd added this to the 2025.1 milestone Dec 2, 2024
seanbudd pushed a commit that referenced this issue Jan 7, 2025
Link to issue number:

#17471

Summary of the issue:

Euro complexSymbol in fi locale causing euro currency numbers to not be read in microsoft excel.

Description of user facing changes

Affects the reading of euro currency numbers in microsoft excel. The behavior should be in line with that of some common locales such as english and spanish where this regex is not present.

Description of development approach

Followed the advice of seanbudd and removed the regex, after spot-checking to verify that this is likely a finnish-only regex and behavior.
@seanbudd
Copy link
Member

seanbudd commented Jan 8, 2025

fixed by #17578

@seanbudd seanbudd closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/i18n existing localisations or internationalisation good first issue github features these at https://github.com/nvaccess/nvda/contribute p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority quick fix triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

No branches or pull requests

3 participants