feat(dashboard): edit step conditions drawer #7417
+175
−68
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import { RiCloseLine, RiGuideFill } from 'react-icons/ri'; | ||
| import { useNavigate } from 'react-router-dom'; | ||
|
|
||
| import { CompactButton } from '@/components/primitives/button-compact'; | ||
| import { StepDrawer } from '@/components/workflow-editor/steps/step-drawer'; | ||
| import { useWorkflow } from '@/components/workflow-editor/workflow-provider'; | ||
| import { useFeatureFlag } from '@/hooks/use-feature-flag'; | ||
| import { FeatureFlagsKeysEnum } from '@novu/shared'; | ||
| import { Button } from '@/components/primitives/button'; | ||
|
|
||
| export const EditStepConditions = () => { | ||
| const navigate = useNavigate(); | ||
| const { workflow, step } = useWorkflow(); | ||
| const isStepConditionsEnabled = useFeatureFlag(FeatureFlagsKeysEnum.IS_STEP_CONDITIONS_ENABLED); | ||
|
|
||
| if (!workflow || !step) { | ||
| return null; | ||
| } | ||
|
|
||
| if (!isStepConditionsEnabled) { | ||
| navigate('..', { relative: 'path' }); | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <StepDrawer title={`Edit ${step?.name} Conditions`}> | ||
| <header className="flex flex-row items-center gap-3 px-3 py-1.5"> | ||
| <div className="mr-auto flex items-center gap-2.5 py-2 text-sm font-medium"> | ||
| <RiGuideFill className="size-4" /> | ||
| <span>Step Conditions</span> | ||
| </div> | ||
|
|
||
| <CompactButton | ||
| icon={RiCloseLine} | ||
| variant="ghost" | ||
| className="size-6" | ||
| onClick={(e) => { | ||
| e.preventDefault(); | ||
| e.stopPropagation(); | ||
| navigate('..', { relative: 'path' }); | ||
| }} | ||
| > | ||
| <span className="sr-only">Close</span> | ||
| </CompactButton> | ||
| </header> | ||
| <div className="mt-auto flex justify-end border-t border-neutral-200 p-3"> | ||
| <Button type="submit" variant="secondary"> | ||
| Save Conditions | ||
| </Button> | ||
| </div> | ||
| </StepDrawer> | ||
| ); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,78 +1,17 @@ | ||
| import { useWorkflow } from '@/components/workflow-editor/workflow-provider'; | ||
| import { StepDrawer } from './step-drawer'; | ||
| import { ConfigureStepTemplateForm } from './configure-step-template-form'; | ||
|
|
||
| export const ConfigureStepTemplate = () => { | ||
| const { workflow, update, step } = useWorkflow(); | ||
|
|
||
| if (!workflow || !step) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <StepDrawer title={`Edit ${step?.name}`}> | ||
| <ConfigureStepTemplateForm workflow={workflow} step={step} update={update} /> | ||
|
There was a problem hiding this comment. Moved the shared code to the |
||
| </StepDrawer> | ||
| ); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| import { motion } from 'motion/react'; | ||
| import { useNavigate } from 'react-router-dom'; | ||
|
|
||
| import { Sheet, SheetContentBase, SheetDescription, SheetPortal, SheetTitle } from '@/components/primitives/sheet'; | ||
| import { VisuallyHidden } from '@/components/primitives/visually-hidden'; | ||
| import { PageMeta } from '@/components/page-meta'; | ||
| import { useWorkflow } from '@/components/workflow-editor/workflow-provider'; | ||
| import { StepTypeEnum } from '@novu/shared'; | ||
| import { cn } from '@/utils/ui'; | ||
|
|
||
| const transitionSetting = { ease: [0.29, 0.83, 0.57, 0.99], duration: 0.4 }; | ||
| const stepTypeToClassname: Record<string, string | undefined> = { | ||
| [StepTypeEnum.IN_APP]: 'sm:max-w-[600px]', | ||
| [StepTypeEnum.EMAIL]: 'sm:max-w-[800px]', | ||
| }; | ||
|
|
||
| export const StepDrawer = ({ children, title }: { children: React.ReactNode; title?: string }) => { | ||
| const navigate = useNavigate(); | ||
| const { workflow, step } = useWorkflow(); | ||
| const handleCloseSheet = () => { | ||
| if (step) { | ||
| // Do not use relative path here, calling twice will result in moving further back | ||
| navigate(`../steps/${step.slug}`); | ||
| } | ||
| }; | ||
|
|
||
| if (!workflow || !step) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <> | ||
| <PageMeta title={title} /> | ||
| <Sheet modal={false} open> | ||
| <motion.div | ||
| initial={{ | ||
| opacity: 0, | ||
| }} | ||
| animate={{ | ||
| opacity: 1, | ||
| }} | ||
| exit={{ | ||
| opacity: 0, | ||
| }} | ||
| className="fixed inset-0 z-50 h-screen w-screen bg-black/20" | ||
| transition={transitionSetting} | ||
| /> | ||
| <SheetPortal> | ||
| <SheetContentBase asChild onInteractOutside={handleCloseSheet} onEscapeKeyDown={handleCloseSheet}> | ||
| <motion.div | ||
| initial={{ | ||
| x: '100%', | ||
| }} | ||
| animate={{ | ||
| x: 0, | ||
| }} | ||
| exit={{ | ||
| x: '100%', | ||
| }} | ||
| transition={transitionSetting} | ||
| className={cn( | ||
| 'bg-background fixed inset-y-0 right-0 z-50 flex h-full w-3/4 flex-col border-l shadow-lg outline-none sm:max-w-[600px]', | ||
| stepTypeToClassname[step.type] | ||
| )} | ||
| > | ||
| <VisuallyHidden> | ||
| <SheetTitle /> | ||
| <SheetDescription /> | ||
| </VisuallyHidden> | ||
| {children} | ||
| </motion.div> | ||
| </SheetContentBase> | ||
| </SheetPortal> | ||
| </Sheet> | ||
| </> | ||
| ); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The empty edit step conditions drawer. In the upcoming PRs I'll add the conditions editor and form and will restructure components in the body.