feat(dashboard): edit step conditions drawer #7417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
requested review from
SokratisVidros,
BiswaViraj,
ChmaraX,
tatarco,
djabarovgeorge and
desiprisg
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LaunchDarkly flag references🔍 1 flag added or modified
|
LetItRock
commented
Jan 2, 2025
| import { FeatureFlagsKeysEnum } from '@novu/shared'; | ||
| import { Button } from '@/components/primitives/button'; | ||
|
|
||
| export const EditStepConditions = () => { |
There was a problem hiding this comment.
The empty edit step conditions drawer. In the upcoming PRs I'll add the conditions editor and form and will restructure components in the body.
Comment on lines
+320
to
+340
| {isStepConditionsEnabled && ( | ||
| <> | ||
| <SidebarContent> | ||
| <Link to={'./conditions'} relative="path" state={{ stepType: step.type }}> | ||
| <Button | ||
| variant="secondary" | ||
| mode="outline" | ||
| className="flex w-full justify-start gap-1.5 text-xs font-medium" | ||
| > | ||
| <RiGuideFill className="h-4 w-4 text-neutral-600" /> | ||
| Step Conditions | ||
| <span className="ml-auto flex items-center gap-0.5"> | ||
| <span>0</span> | ||
| <RiArrowRightSLine className="ml-auto h-4 w-4 text-neutral-600" /> | ||
| </span> | ||
| </Button> | ||
| </Link> | ||
| </SidebarContent> | ||
| <Separator /> | ||
| </> | ||
| )} |
There was a problem hiding this comment.
Step Conditions button in the Configure Step sidebar
| <RiGuideFill className="h-4 w-4 text-neutral-600" /> | ||
| Step Conditions | ||
| <span className="ml-auto flex items-center gap-0.5"> | ||
| <span>0</span> |
There was a problem hiding this comment.
For now, I've hardcoded the value until we have the same logic so we can calculate it
| </SheetPortal> | ||
| </Sheet> | ||
| </> | ||
| <StepDrawer title={`Edit ${step?.name}`}> |
There was a problem hiding this comment.
Moved the shared code to the StepDrawer which is used to edit step template and conditions
scopsy
approved these changes
Jan 3, 2025
@novu/client
@novu/headless
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/shared
commit: |
SokratisVidros
approved these changes
Jan 7, 2025
apps/dashboard/src/components/workflow-editor/steps/conditions/edit-step-conditions.tsx
Outdated
Show resolved
Hide resolved
…/edit-step-conditions.tsx Co-authored-by: Sokratis Vidros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Step Conditions Empty Drawer:
Screenshots
Screen.Recording.2025-01-02.at.15.18.18.mov