-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): Open step template drawer on Add Step #7406
base: next
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,6 +28,14 @@ export const STEP_TYPE_LABELS: Record<StepTypeEnum, string> = { | |
[StepTypeEnum.CUSTOM]: 'Custom', | ||
}; | ||
|
||
export const AUTO_OPEN_DRAWER_AFTER_CREATION_STEP_TYPES: StepTypeEnum[] = [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Every TEMPLATE_CONFIGURABLE_STEP_TYPES should allow for the same behavior. So we don't need a separate enum for this. Moreover, these enums have a bit of a code smell as the UI around drawers should work independently of the step types. We will get back to that soon; meanwhile, let's not add another constant array of array steps. |
||
StepTypeEnum.EMAIL, | ||
StepTypeEnum.SMS, | ||
StepTypeEnum.IN_APP, | ||
StepTypeEnum.CHAT, | ||
StepTypeEnum.PUSH, | ||
]; | ||
|
||
export const DEFAULT_CONTROL_DELAY_AMOUNT = 30; | ||
export const DEFAULT_CONTROL_DELAY_UNIT = TimeUnitEnum.SECONDS; | ||
export const DEFAULT_CONTROL_DELAY_TYPE = 'regular'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better DX to do