feat(dashboard): Open step template drawer on Add Step #7406
+99
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
desiprisg
force-pushed
the
nv-4972-open-step-template-drawer-on-add-step
branch
from
4eb716f to
07450dd
Compare
desiprisg
force-pushed
the
nv-4972-open-step-template-drawer-on-add-step
branch
from
07450dd to
7c4a43e
Compare
scopsy
reviewed
Dec 30, 2024
desiprisg
force-pushed
the
nv-4972-open-step-template-drawer-on-add-step
branch
from
7c4a43e to
5635caa
Compare
desiprisg
force-pushed
the
nv-4972-open-step-template-drawer-on-add-step
branch
from
5635caa to
5fa1330
Compare
SokratisVidros
requested changes
Jan 7, 2025
| @@ -28,6 +28,14 @@ export const STEP_TYPE_LABELS: Record<StepTypeEnum, string> = { | |||
| [StepTypeEnum.CUSTOM]: 'Custom', | |||
| }; | |||
|
|
|||
| export const AUTO_OPEN_DRAWER_AFTER_CREATION_STEP_TYPES: StepTypeEnum[] = [ | |||
There was a problem hiding this comment.
Every TEMPLATE_CONFIGURABLE_STEP_TYPES should allow for the same behavior. So we don't need a separate enum for this.
Moreover, these enums have a bit of a code smell as the UI around drawers should work independently of the step types. We will get back to that soon; meanwhile, let's not add another constant array of array steps.
| @@ -105,9 +111,13 @@ export const WorkflowProvider = ({ children }: { children: ReactNode }) => { | |||
| const isUpdatePatchPending = isPatchPending || isUpdatePending || hasPendingItems; | |||
|
|
|||
| const update = useCallback( | |||
| (data: UpdateWorkflowDto) => { | |||
| ({ data, onSuccess }: { data: UpdateWorkflowDto; onSuccess?: (workflow: WorkflowResponseDto) => void }) => { | |||
There was a problem hiding this comment.
I think it would be better DX to do
(data: UpdateWorkflowDto, { onSuccess }: { onSuccess?: (workflow: WorkflowResponseDto) => void }) => {```
It's also a safer change and doesn't introduce the super generic data key across the board.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
To make sure that the user can focus on modifying the content immediately after adding a step and doesn't get distracted by errors for missing content, we are opening the configure drawer right after the step is added.
Screenshots
Screen.Recording.2024-12-30.at.12.09.33.PM.mov
Expand for optional sections
Related enterprise PR
Special notes for your reviewer