-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cherry-pick: cherry pick from main to release-1.3 branch #505
Conversation
This PR improves log readability of the library. Signed-off-by: Patrick Zheng <[email protected]>
Fix: - update the command to search script file in `.` instead of `scripts/` folder to avoid returning an error. --------- Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Patrick Zheng <[email protected]> Co-authored-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>
…taryproject#501) Signed-off-by: Patrick Zheng <[email protected]>
…oject#503) Signed-off-by: Patrick Zheng <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.3 #505 +/- ##
============================================
Coverage 80.97% 80.97%
============================================
Files 34 34
Lines 3080 3080
============================================
Hits 2494 2494
Misses 455 455
Partials 131 131 ☔ View full report in Codecov by Sentry. |
Should we include #504 in this PR? |
No, the plan is to bump up release-1.3 branch after the cherry pick, because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR cherry picks from main to
release-1.3
branch forv1.3.0
release.This PR targets on
release-1.3
branch.