Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: cherry pick from main to release-1.3 branch #505

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

Two-Hearts
Copy link
Contributor

This PR cherry picks from main to release-1.3 branch for v1.3.0 release.

This PR targets on release-1.3 branch.

Two-Hearts and others added 4 commits January 15, 2025 14:23
This PR improves log readability of the library.

Signed-off-by: Patrick Zheng <[email protected]>
Fix:
- update the command to search script file in `.` instead of `scripts/`
folder to avoid returning an error.

---------

Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Co-authored-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.97%. Comparing base (97ac273) to head (84d0d15).
Report is 5 commits behind head on release-1.3.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.3     #505   +/-   ##
============================================
  Coverage        80.97%   80.97%           
============================================
  Files               34       34           
  Lines             3080     3080           
============================================
  Hits              2494     2494           
  Misses             455      455           
  Partials           131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao
Copy link
Contributor

Should we include #504 in this PR?

@Two-Hearts
Copy link
Contributor Author

Should we include #504 in this PR?

No, the plan is to bump up release-1.3 branch after the cherry pick, because go mod tidy might bring in new change.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 6d122d5 into notaryproject:release-1.3 Jan 15, 2025
9 checks passed
@Two-Hearts Two-Hearts deleted the release-1.3 branch January 15, 2025 06:47
@Two-Hearts Two-Hearts mentioned this pull request Jan 15, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants