Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: release v1.3.0 #507

Merged
merged 1 commit into from
Jan 16, 2025
Merged

bump: release v1.3.0 #507

merged 1 commit into from
Jan 16, 2025

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Jan 15, 2025 •
edited
Loading

Release

This would mean tagging 31ee0d6 as v1.3.0 to release.

Vote

We need at least 4 approvals from 6 maintainers to release notation-go v1.3.0.

What's Changed

Full Changelog:
v1.3.0-rc.2...31ee0d6

Actions

Please review the PR and vote by approving.

@Two-Hearts
bump: release v1.3.0
31ee0d6 
Signed-off-by: Patrick Zheng <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.97%. Comparing base (6571758) to head (31ee0d6).
Report is 2 commits behind head on release-1.3.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-1.3     #507   +/-   ##
============================================
  Coverage        80.97%   80.97%           
============================================
  Files               34       34           
  Lines             3080     3080           
============================================
  Hits              2494     2494           
  Misses             455      455           
  Partials           131      131

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Two-Hearts
Copy link
Contributor Author

LGTM

shizhMSFT
shizhMSFT approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 1864576 into notaryproject:release-1.3 Jan 16, 2025
9 checks passed
@Two-Hearts Two-Hearts deleted the release-1.3 branch January 16, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Two-Hearts @priteshbandi @shizhMSFT @JeyJeyGao