Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: more ncrypto #56792

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 27, 2025

No description provided.

@jasnell jasnell requested a review from anonrig January 27, 2025 16:08
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 27, 2025
@nodejs-github-bot

This comment was marked as outdated.

@jasnell jasnell force-pushed the jasnell/ncrypto-big-push-next branch from ab6d9ec to 35f3519 Compare January 27, 2025 16:16
deps/ncrypto/ncrypto.cc Outdated Show resolved Hide resolved
deps/ncrypto/ncrypto.cc Show resolved Hide resolved
deps/ncrypto/ncrypto.cc Show resolved Hide resolved
deps/ncrypto/ncrypto.h Show resolved Hide resolved
src/crypto/crypto_aes.cc Show resolved Hide resolved
@jasnell jasnell force-pushed the jasnell/ncrypto-big-push-next branch from 35f3519 to 1872cc6 Compare January 27, 2025 16:44
@jasnell jasnell force-pushed the jasnell/ncrypto-big-push-next branch from 1872cc6 to a69e251 Compare January 27, 2025 17:08
@nodejs-github-bot

This comment was marked as outdated.

This comment was marked as outdated.

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2025
@lpinca
Copy link
Member

lpinca commented Jan 27, 2025

@anonrig did you mean AIX? @nodejs/platform-aix

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 27, 2025

@anonrig
Copy link
Member

anonrig commented Jan 27, 2025

@anonrig did you mean AIX? @nodejs/platform-aix

Yes. I removed my original comment. Here's the link: https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix72-ppc64/55663/

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 27, 2025
@richardlau
Copy link
Member

@anonrig did you mean AIX? @nodejs/platform-aix

Yes. I removed my original comment. Here's the link: https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix72-ppc64/55663/

FWIW https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix72-ppc64/55663/consoleFull

17:36:52 not ok 1107 parallel/test-esm-loader-hooks-inspect-wait
17:36:52   ---
17:36:52   duration_ms: 948.74300
17:36:52   severity: fail
17:36:52   exitcode: 1
17:36:52   stack: |-
17:36:52     [test] Connecting to a child Node process
17:36:52     [test] Testing /json/list
17:36:52     [err] Debugger listening on ws://127.0.0.1:37400/3f260167-b9fb-45e9-926c-48118ea2842c
17:36:52     [err] For help, see: https://nodejs.org/en/docs/inspector
17:36:52     [err] 
17:36:52     [err] Debugger attached.
17:36:52     [err] 
17:36:52     [err] Waiting for the debugger to disconnect...
17:36:52     [err] 
17:36:52     [err] Assertion failed: __EX, file  ../deps/uv/src/unix/stream.c, line 1299
17:36:52     [err] 
17:36:52     [err] child process crashed, signal SIGABRT
17:36:52     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
17:36:52     
17:36:52     null !== 0
17:36:52     
17:36:52         at runTest (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix72-ppc64/test/parallel/test-esm-loader-hooks-inspect-wait.js:27:10)
17:36:52         at process.processTicksAndRejections (node:internal/process/task_queues:105:5) {
17:36:52       generatedMessage: true,
17:36:52       code: 'ERR_ASSERTION',
17:36:52       actual: null,
17:36:52       expected: 0,
17:36:52       operator: 'strictEqual'
17:36:52     }
17:36:52     1
17:36:52   ...

This is #54346 and not AIX specific (when I opened that it was predominantly seen on Linux, where it was marked flaky as part of #54802). I'll open a PR to extend the flaky status to the other platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants