Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the possibility to cancel goals and fixes the preempt/ execution timeouts #1

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

RichardvdK
Copy link

Sorry for the "big diff", but this file needed some love. :)
Implement canceling of goals as that was not possible before

The biggest changes are:

  • Fixed the execution and preemption timeout timers
  • Made 'outcomes' a param to make it compatible with your state machine
  • Updated state names to ROS2 convention (preempt -> cancel)
  • added extra intermediate internal state for preemption and used state enum instead of global vars
  • added function to wait for cancelation request response with timeout

…t timers, make 'outcomes' a param, add extra intermediate internal state and use state enum instead of global var, add function to wait for cancelation request response
@MCFurry
Copy link
Member

MCFurry commented Feb 12, 2024

LGTM! I think we can easily point this to the forked repo?

@Timple
Copy link
Member

Timple commented Feb 13, 2024

I don't see anything surprising, thanks for picking this up.
I'd forward this PR to the parent repository.

@RichardvdK RichardvdK requested a review from Rayman February 13, 2024 10:52
@RichardvdK RichardvdK requested a review from Timple February 15, 2024 13:11
@MCFurry MCFurry merged commit a0dba1b into ros2 Oct 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants