-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contacts activity #3936
Contacts activity #3936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job! 👍🏾 It works on my emulator
Just need to implement
- Create new public conversation
- Proper theming
Me and @mahibi are also doing a lot of work on #3952 to get offline conversations + chatting working. I don't think there is much overlap with your PR, but just a heads up in case there are merge conflicts.
app/src/main/java/com/nextcloud/talk/contacts/ContactsActivityCompose.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/talk/contacts/ContactsActivityCompose.kt
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/talk/contacts/ContactsActivityCompose.kt
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/talk/contacts/ContactsActivityCompose.kt
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/talk/contacts/ContactsActivityCompose.kt
Show resolved
Hide resolved
Great to have a kickoff with jetpack compose 🚀 |
One thing i realized when testing are some bugs that existed already before this PR:
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3936-talk.apk |
@sowjanyakch please also fix warnings from https://app.codacy.com/gh/nextcloud/talk-android/pull-requests/3936/issues |
4c12816
to
136efde
Compare
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
76a3a95
to
1255a0b
Compare
partly resolves #3794
This PR implements ContactsActivity in Jetpack Compose using coroutines.
Image caching for user avatars and theming will be implemented in a different PR.
🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x