Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts activity #3936

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Contacts activity #3936

merged 3 commits into from
Jul 23, 2024

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented May 22, 2024

partly resolves #3794


This PR implements ContactsActivity in Jetpack Compose using coroutines.

  • Display user avatar and name for contacts.
  • Add sticky headers for contacts.
  • Create 1-1 room on clicking a contact.
  • Implement search for contacts.

Image caching for user avatars and theming will be implemented in a different PR.

🖼️ Screenshots

Contacts Search Create room for contacts
contacts search_contacts create_room_for_contacts

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as draft May 22, 2024 14:16
@sowjanyakch sowjanyakch marked this pull request as ready for review July 10, 2024 12:57
@sowjanyakch sowjanyakch requested a review from mahibi July 10, 2024 13:10
@nickvergessen nickvergessen added enhancement New feature or request 3. to review Waiting for reviews feature: 📄 conversations labels Jul 11, 2024
Copy link
Contributor

@rapterjet2004 rapterjet2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! 👍🏾 It works on my emulator

Just need to implement

  • Create new public conversation
  • Proper theming

Me and @mahibi are also doing a lot of work on #3952 to get offline conversations + chatting working. I don't think there is much overlap with your PR, but just a heads up in case there are merge conflicts.

@mahibi
Copy link
Collaborator

mahibi commented Jul 12, 2024

Great to have a kickoff with jetpack compose 🚀
From my side this can be merged once the remarks from Julius are solved and issues/features should be fixed/done in followup PRs.

@mahibi
Copy link
Collaborator

mahibi commented Jul 12, 2024

One thing i realized when testing are some bugs that existed already before this PR:

  1. I have 2 accounts on sermo and with my account "Marcel" i am not able to see the account "marcel2" in the contacts. Maybe i get something wrong but i don't have an idea which could explain why it shouldn't be shown. When i search for it, it appears, but it's not in the list by default.

  2. When opening a conversation and go to Conversation info to add participants, the search is broken. When i enter a name, it won't appear in the results list. Then i delete the search and try and, and then more results appear than before.
    Bug report is search in contact controller buggy on first search #2037

@mahibi mahibi added this to the 20.0.0 milestone Jul 12, 2024
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3936-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi
Copy link
Collaborator

mahibi commented Jul 15, 2024

@sowjanyakch
Can you rebase on master? Or as the rebase was not done regulary and may be difficult now, you can also merge master into this branch. For future branches please always use rebase and do it regulary.

please also fix warnings from https://app.codacy.com/gh/nextcloud/talk-android/pull-requests/3936/issues

Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
@mahibi mahibi disabled auto-merge July 23, 2024 11:18
@mahibi mahibi merged commit eb18abe into master Jul 23, 2024
10 of 19 checks passed
@mahibi mahibi deleted the contacts_activity branch July 23, 2024 11:18
@sowjanyakch sowjanyakch mentioned this pull request Jul 26, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: 📄 conversations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve Contacts activity (group creation, federation invitations, ...)
4 participants