Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts theming #4011

Merged
merged 12 commits into from
Aug 9, 2024
Merged

Contacts theming #4011

merged 12 commits into from
Aug 9, 2024

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Jul 22, 2024

This PR is continuation for PR #3936.

  • Image caching for user avatars.
  • Theming for composable activity (this is partially implemented and I see only white color is applied to components in dark mode and black color is applied to components in light mode. Need to investigate what's causing this issue)
  • unit tests for viewModel.

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as draft July 22, 2024 19:07
@sowjanyakch sowjanyakch force-pushed the contacts_theming branch 3 times, most recently from 8079295 to 4bd1040 Compare July 26, 2024 08:30
@sowjanyakch sowjanyakch self-assigned this Jul 26, 2024
@sowjanyakch sowjanyakch marked this pull request as ready for review July 26, 2024 08:31
@sowjanyakch sowjanyakch added this to the 20.0.0 milestone Jul 26, 2024
@mahibi
Copy link
Collaborator

mahibi commented Aug 7, 2024

fine for me. just rebase and squash to get rid of the old commits which code is already in master...

@mahibi
Copy link
Collaborator

mahibi commented Aug 7, 2024

conspicuous/known issues:

  • the status bar should be aligned to the other colors
  • the category letters are blue but should be themed
    (can be done in followup PRs, more important is to focus on functionality at create conversation screen for now)

grafik

Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
@mahibi mahibi force-pushed the contacts_theming branch from 1672ca0 to 4508cbb Compare August 9, 2024 13:50
@mahibi mahibi merged commit 85b94d6 into master Aug 9, 2024
15 of 17 checks passed
@mahibi mahibi deleted the contacts_theming branch August 9, 2024 13:51
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Codacy

Lint

TypemasterPR
Warnings9084
Errors129131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Lint increased!

Copy link
Contributor

github-actions bot commented Aug 9, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4011-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants