Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PHP 8.3 support #797

Merged
merged 7 commits into from
Dec 18, 2023
Merged

feat: add PHP 8.3 support #797

merged 7 commits into from
Dec 18, 2023

Conversation

bduranleau-nr
Copy link
Contributor

Adds non-OAPI PHP 8.3 support to the agent.

@CRC-Mismatch
Copy link

CRC-Mismatch commented Dec 7, 2023

I guess someone with permissions needs to manually run the _make-agent workflow for both amd64 and arm64 platforms, then re-run the checks 😶

Either that, or (judging by no history being shown) someone with access to the private DockerHub repo needs to build and push the 4 new tags before rerunning the checks...

Even if almost all of them would fail, I think it would be really interesting to see the depth of "how much work" it will still take to get it working - it would also give a nice way for any seasoned developer to estimate how far we are from PHP 8.3 support. Also, maybe with more inputs publicly available on it, more people could join in and (knowing what's failing) speed up the process 🤷‍♂️

This was referenced Dec 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8fe3a8) 78.46% compared to head (b74483d) 78.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #797   +/-   ##
=======================================
  Coverage   78.46%   78.47%           
=======================================
  Files         189      189           
  Lines       26335    26335           
=======================================
+ Hits        20665    20666    +1     
+ Misses       5670     5669    -1     
Flag Coverage Δ
agent-for-php-7.0 77.22% <ø> (ø)
agent-for-php-7.1 76.94% <ø> (ø)
agent-for-php-7.2 77.50% <ø> (ø)
agent-for-php-7.3 77.52% <ø> (ø)
agent-for-php-7.4 77.31% <ø> (+<0.01%) ⬆️
agent-for-php-8.0 77.40% <ø> (+<0.01%) ⬆️
agent-for-php-8.1 77.36% <ø> (+<0.01%) ⬆️
agent-for-php-8.2 77.15% <ø> (+<0.01%) ⬆️
agent-for-php-8.3 77.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bduranleau-nr bduranleau-nr marked this pull request as ready for review December 15, 2023 15:41
@lavarou lavarou added this to the next-release milestone Dec 15, 2023
Copy link
Member

@lavarou lavarou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think PHP 8.3 needs to be added here as well.

@bduranleau-nr
Copy link
Contributor Author

I think PHP 8.3 needs to be added here as well.

@lavarou Fixed in a3741c7

@bduranleau-nr bduranleau-nr merged commit 2f6cb3f into dev Dec 18, 2023
61 checks passed
@bduranleau-nr bduranleau-nr deleted the php-83-non-oapi branch December 18, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants