-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add PHP 8.3 support #797
Conversation
I guess someone with permissions needs to manually run the _make-agent workflow for both Either that, or (judging by no history being shown) someone with access to the private DockerHub repo needs to build and push the 4 new tags before rerunning the checks... Even if almost all of them would fail, I think it would be really interesting to see the depth of "how much work" it will still take to get it working - it would also give a nice way for any seasoned developer to estimate how far we are from PHP 8.3 support. Also, maybe with more inputs publicly available on it, more people could join in and (knowing what's failing) speed up the process 🤷♂️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #797 +/- ##
=======================================
Coverage 78.46% 78.47%
=======================================
Files 189 189
Lines 26335 26335
=======================================
+ Hits 20665 20666 +1
+ Misses 5670 5669 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a35ab46
to
c56f4a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think PHP 8.3 needs to be added here as well.
chore: Changes for PHP 8.3
Adds non-OAPI PHP 8.3 support to the agent.