feat(agent): add support for PHP 8.3 #737
Conversation
Codecov Report
@@ Coverage Diff @@
## oapi #737 +/- ##
=======================================
Coverage 78.59% 78.59%
=======================================
Files 191 191
Lines 26627 26627
=======================================
Hits 20928 20928
Misses 5699 5699
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
PHP 8.3 will invoke the user_exception_handler when an exception is encountered (if one is registered). This results in an inversion of the expectation from pre-8.3 of failing out of the zend_try/zend_catch block of code that sets the zend_result to FAILURE and returns NULL to the expr variable assigned to nr_php_call(). 8.3 logic allows our newrelic_exception_handler to intercept the exception, skip the zend_catch, and return SUCCESS in nr_php_call_user_func() which returns a non-NULL value.
|
After a great start in September, it now seems it has been a bit silent on this PR. Any update on what still would need to happen? The final release candidate will be available two days from now, and the general availability release will be in three weeks: https://wiki.php.net/todo/php83 |
|
Hello @rvanlaak, the Php 8.3 release depends on our work in ObserverAPI. Once resolved 8.3 should be straightforward. |
|
Thanks for the update @Ak-x , that looks like a major change to the approach, exciting! Work on ObserverAPI started over a year ago and does not have a draft PR yet, while in the meanwhile the PHP 8.2 support on the agent was able to get released. Can you share some more visibility on the prioritization and dependency of ObserverAPI you refer to, over agent language support? Teams are eager on that in order to being able to complete the tech roadmapping they're working on. |
|
PHP 8.3 already released |
|
Bump |
|
Based on the branch name of a new draft PR on adding PHP 8.3 support: #797, it seems the dependency on ObserverAPI has been dropped. |
|
PHP 8.3 support was released in 10.15.0.4. |
No description provided.