Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use venv on docker image #3

Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat: use venv on docker image #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ce13c5
feat: use venv on docker image
leoparente Nov 19, 2024
ce85210
Reduce image size by using slim
leoparente Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions device-discovery/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,22 @@
FROM python:3.12-bullseye

RUN addgroup --system netdev && useradd -m --shell /bin/bash -G netdev appuser && echo "appuser ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
FROM python:3.12-slim-bullseye AS builder

WORKDIR /usr/src/app

COPY device-discovery/ ./device-discovery

RUN pip install --no-cache-dir ./device-discovery/
RUN python -m venv /opt/venv && \
. /opt/venv/bin/activate && \
pip install --no-cache-dir ./device-discovery && \
deactivate

FROM python:3.12-slim-bullseye

RUN addgroup --system netdev && useradd -m --shell /bin/bash -G netdev appuser && echo "appuser ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers

COPY --from=builder /opt/venv /opt/venv

RUN rm -rf ./device-discovery
# Activate virtual environment for all users
ENV PATH="/opt/venv/bin:$PATH"

USER appuser

Expand Down