Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use venv on docker image #3

Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat: use venv on docker image #3

merged 2 commits into from
Nov 19, 2024

Conversation

leoparente
Copy link
Contributor

No description provided.

@leoparente leoparente self-assigned this Nov 19, 2024
@linear Linear
Copy link

linear bot commented Nov 19, 2024

OBS-561 Use venv on device-discovery docker image

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
device_discovery
   discovery.py36294%93–96
   main.py25196%59
   parser.py43295%54, 87
   server.py68494%33–35, 128, 131
   version.py7186%14
device_discovery/policy
   runner.py64198%49
TOTAL3881197% 

Tests Skipped Failures Errors Time
56 0 💤 0 ❌ 0 🔥 6.390s ⏱️

mfiedorowicz
mfiedorowicz reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When building docker image from this Dockerfile, image size is suspiciously large (999MB), is that expected?

device-discovery/docker/Dockerfile Outdated Show resolved Hide resolved
@mfiedorowicz
Copy link
Member

When building docker image from this Dockerfile, image size is suspiciously large (999MB), is that expected?

FYI: using python:3.12-slim-bullseye shrinks image to ~235 MB

@leoparente
Copy link
Contributor Author

When building docker image from this Dockerfile, image size is suspiciously large (999MB), is that expected?

FYI: using python:3.12-slim-bullseye shrinks image to ~235 MB

good call @mfiedorowicz
image

@leoparente leoparente merged commit bcfffbc into develop Nov 19, 2024
6 checks passed
@leoparente leoparente deleted the feat/OBS-561-venv-docker-image branch November 19, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

Assignees

@leoparente leoparente

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoparente @mfiedorowicz