Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in scheduled unit/e2e tests #1898

Open
wants to merge 1 commit into
base: dev/1.x
Choose a base branch
from
Open

Fix errors in scheduled unit/e2e tests #1898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/e2e/standard/test_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,14 @@ def test_pil_image(self, container: MetadataContainer):
def test_matplotlib_figure(self, container: MetadataContainer):
figure = generate_matplotlib_figure()
container["matplotlib_figure"] = figure

@pytest.mark.skip(
reason="Conversion to html fails for matplotlib axes with polar projection. "
"The test without cdn passes because matplotlib figure is converted to an image."
)
@pytest.mark.parametrize("container", ["run"], indirect=True)
def test_matplotlib_figure_cdn(self, container: MetadataContainer):
figure = generate_matplotlib_figure()
container["matplotlib_figure_cdn"] = File.as_html(figure, include_plotlyjs="cdn")

@pytest.mark.parametrize("container", ["run"], indirect=True)
Expand Down
15 changes: 14 additions & 1 deletion tests/unit/neptune/new/internal/utils/test_images.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import numpy
import pandas
import plotly.express as px
import pytest
import seaborn as sns
from bokeh.plotting import figure
from matplotlib import pyplot
Expand Down Expand Up @@ -188,6 +189,18 @@ def test_get_html_from_matplotlib_figure(self):
# then
self.assertTrue(result.startswith('<html>\n<head><meta charset="utf-8" />'))

@pytest.mark.skip(reason="Conversion to html fails for matplotlib axes with polar projection")
def test_get_html_from_matplotlib_figure_polar(self):
fig = pyplot.figure()
rect = 0.1, 0.1, 0.8, 0.8
fig.add_axes(rect, polar=True)

# when
result = get_html_content(fig)

# then
self.assertTrue(result.startswith('<html>\n<head><meta charset="utf-8" />'))

def test_get_html_from_plotly(self):
# given
df = px.data.tips()
Expand Down Expand Up @@ -232,7 +245,7 @@ def test_get_html_from_altair(self):
result = get_html_content(chart)

# then
self.assertTrue(result.startswith("<!DOCTYPE html>\n<html>\n<head>\n <style>"))
self.assertTrue(result.startswith("<!DOCTYPE html>\n<html>\n<head>\n"))

def test_get_html_from_bokeh(self):
# given
Expand Down
Loading