Fix errors in scheduled unit/e2e tests #1898
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsosn
force-pushed
the
ms/fix-scheduled-tests
branch
from
d5bc142 to
352f71c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/1.x #1898 +/- ##
===========================================
- Coverage 77.53% 75.59% -1.94%
===========================================
Files 303 303
Lines 15384 15366 -18
===========================================
- Hits 11928 11616 -312
- Misses 3456 3750 +294
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some errors detected in
https://github.com/neptune-ai/neptune-client/actions/runs/12593563769/job/35099807934
html format seems to slightly differ between altair 5.4.1 and 5.5.0
https://github.com/neptune-ai/neptune-client/actions/runs/12593515205/job/35099649318
problem was actually introduced in #1881 The new conversion method does not work for all figures we have in our test cases. It's likely fine to accept that the support is limited