Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global block entities not being updated for empty sections #1865

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

Technici4n
Copy link
Member

@Technici4n Technici4n commented Jan 17, 2025

Without this fix, "ghost" global BERs can continue to be rendered when the section becomes empty. This can be reproduced with structure blocks in vanilla, see MC-279596 that I just opened.

Credits to XFact who found the right place to fix the issue.

Fixes AztechMC/Modern-Industrialization#1008.

@neoforged-automation neoforged-automation bot added the 1.21.4 Targeted at Minecraft 1.21.4 label Jan 17, 2025
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jan 17, 2025

  • Publish PR to GitHub Packages

Last commit published: 165c8d4bf991a14c18b23037b2735ada9c78da72.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1865' // https://github.com/neoforged/NeoForge/pull/1865
        url 'https://prmaven.neoforged.net/NeoForge/pr1865'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1865.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1865
cd NeoForge-pr1865
curl -L https://prmaven.neoforged.net/NeoForge/pr1865/net/neoforged/neoforge/21.4.61-beta-pr-1865-fix-global-be-empty-section/mdk-pr1865.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@embeddedt embeddedt merged commit 5309e31 into neoforged:1.21.x Jan 18, 2025
7 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.60-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error vanilla bug A bug or error in the base Minecraft game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destroying MI multiblock controllers can leave phantom hatch overlays
5 participants