Destroying MI multiblock controllers can leave phantom hatch overlays

[James103]

Version info

Modern Industrialization 2.2.31
Minecraft 1.20.1
NeoForge 21.1.90

Expected result

Hatch overlays are freed and no longer rendered when the corresponding multiblock controller is destroyed.

Actual result

When destroying multiblock controllers via non-player means such as an explosion or /fill ... air, some of the hatch overlays remain visible when holding the correct hatch type, even if there are no multiblock controller blocks left in the area.

Steps to reproduce

Run these two commands in succession:

fill ~5 ~5 ~5 ~14 ~14 ~14 modern_industrialization:coke_oven
fill ~5 ~5 ~5 ~14 ~14 ~14 air

Then hold a fluid or item input or output hatch and look for hatch overlays.

Alternatively,

1. Run fill ~5 ~5 ~5 ~14 ~14 ~14 modern_industrialization:coke_oven
2. Run summon minecraft:creeper ~10 ~10 ~10 {powered:1,Fuse:0} repeatedly until all of the coke oven controller blocks are destroyed.
3. Most of the hatch overlays will be removed, but some will remain visible when holding the correct hatch type.

[Technici4n]

Ok this took me a while. You managed to find a vanilla bug! See neoforged/NeoForge#1865.