Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accounts setup for other regions #534

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Fix accounts setup for other regions #534

merged 1 commit into from
Dec 22, 2023

Conversation

lorenyu
Copy link
Contributor

@lorenyu lorenyu commented Dec 21, 2023

Ticket

Resolves #526

Changes

see title

Context for reviewers

@daphnegold discovered a regression where set-up-account failed when region was not us-east-1

Testing

Developed and tested on platform-test in navapbc/platform-test#83

@lorenyu lorenyu requested a review from daphnegold December 22, 2023 00:08
daphnegold
daphnegold approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@daphnegold daphnegold left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of our awesome bid testers found this, and I just passed it along. Didn't test but the array looks reasonable since it'll expand into multiple arguments now (if I understood the issue correctly). Trust that it works. 👍

@lorenyu lorenyu merged commit 649f177 into main Dec 22, 2023
9 checks passed
@lorenyu lorenyu deleted the lorenyu/fixaccountregion branch December 22, 2023 01:47
@lorenyu lorenyu mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daphnegold daphnegold daphnegold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up account breaks with regions other than us-east-1
2 participants
@lorenyu @daphnegold