Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accounts setup for other regions #83

Closed
wants to merge 3 commits into from
Closed

Fix accounts setup for other regions #83

wants to merge 3 commits into from

Conversation

lorenyu
Copy link
Collaborator

@lorenyu lorenyu commented Dec 21, 2023 •
edited
Loading

Ticket

Resolves navapbc/template-infra#526

Changes

see title

Context for reviewers

@daphnegold discovered a regression where set-up-account failed when region was not us-east-1

Testing

  1. Configured my aws credentials to use us-east-2
    image

  2. Configured project config's default region to us-east-2 and set project name to a new project to avoid conflict
    image

  3. Ran

    make infra-set-up-account ACCOUNT_NAME=tmp
    image

  4. Destroyed everything afterwards

@lorenyu lorenyu mentioned this pull request Dec 21, 2023
Merged
@lorenyu
Copy link
Collaborator Author

lorenyu commented Dec 22, 2023

Done in navapbc/template-infra#534

@lorenyu lorenyu closed this Dec 22, 2023
@lorenyu lorenyu deleted the lorenyu/fixaccountregion branch December 22, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up account breaks with regions other than us-east-1
1 participant
@lorenyu