-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-rails: Add based on template-application-rails
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doshitan
force-pushed
the
doshitan/add-rails
branch
from
January 3, 2025 18:13
7c5cfc3
to
ddf4758
Compare
doshitan
force-pushed
the
doshitan/add-rails
branch
2 times, most recently
from
January 16, 2025 19:42
d087d86
to
510ea04
Compare
…ly filesystem in the container
doshitan
force-pushed
the
doshitan/add-rails
branch
from
January 21, 2025 16:08
2b02720
to
cefcc1a
Compare
doshitan
force-pushed
the
doshitan/add-rails
branch
from
January 21, 2025 16:33
cefcc1a
to
df9ba72
Compare
doshitan
force-pushed
the
doshitan/add-rails
branch
2 times, most recently
from
January 22, 2025 16:39
eae3956
to
2156262
Compare
doshitan
changed the title
Add a rails app
app-rails: Add based on Jan 22, 2025
template-application-rails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves navapbc/template-infra#762
Changes
Add application based on
template-application-rails
, following its guide[1].This required some edits of infra configuration, callouts:
curl
in container healthchecks[1] https://github.com/navapbc/template-application-rails/tree/881cc71e062e5e7c44b55d28946a84ce13123d9d/template-only-docs/Deployment.md
Context for reviewers
TODOs:
app_has_dev_env_setup
answertemplate-infra
first? We'll upstream, but can carry the custom changes here for now.Current status: service running
Do some basic manual tests at: https://app-rails.platform-test-dev.navateam.com/
(create account, login, etc)
Setup
Code
Before all the new releases were tagged:
After the releases:
Infra/Setting up dev environment
make infra-update-network NETWORK_NAME=dev # it wanted to remove some notification VPC endpoints, said no
Configuring network after Cognito/HTTPS config
Accidentally running against "prod" account the first time
Testing
Dev environment: https://app-rails.platform-test-dev.navateam.com/
Created account, logged in. Not much else to test.
Preview environment
♻️ Environment destroyed ♻️
Preview environment
♻️ Environment destroyed ♻️