Support Platform CLI #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match template-infra default
It's currently empty, but if there is content, it'd basically always conflict with other templates?
Use template-infra's project-wide version since we don't need any app overrides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Switch to the Platform CLI[1] for install/update.
copier.ymlconfig filetemplate/{{app_name}}/. And tag theapp services with
{{app_name}}. In a multi-app environment, it isunreasonable (and high source of conflicts on update) for a single application
template to provide a root Compose file. So apps should provide their own
Compose files, the the project can import them into one project-wide Compose
file if desired.
.grype.yml. Can use template-infra's project-wide versionsince we don't need any app overrides.
pfml-starter-kit[1] https://github.com/navapbc/platform-cli
Testing
navapbc/platform-test#148
https://github.com/navapbc/pfml-starter-kit-app/pull/239