fix(maker): Fix icon argument usage in UiElementMaker #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kiwikoti
approved these changes
Jul 30, 2024
welcoMattic
force-pushed
the
fix/ui-element-maker-icon
branch
from
af8c6c4 to
71ed066
Compare
delyriand
approved these changes
Jul 30, 2024
maximehuran
reviewed
Jul 31, 2024
welcoMattic
force-pushed
the
fix/ui-element-maker-icon
branch
from
71ed066 to
5ca8665
Compare
welcoMattic
force-pushed
the
fix/ui-element-maker-icon
branch
from
5ca8665 to
c4ce8a6
Compare
maximehuran
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite specifying
iconargument onmake:ui-elementcommand, the generated class contained alwaysmap pinicon name.The argument was not used in
UiElementMakerclass.This PR fix it, and set
squareas neutral default icon, WDYT?Warning
I reduced the PHPStan level from
maxto8, becausemaxlevel (currently9) only brings constraint aboutmixedtype which is more annoying than useful. Even PHPStan itself is configured to8(https://github.com/phpstan/phpstan-src/blob/1.12.x/build/phpstan.neon#L14)