Merge pull request #234 from monsieurbiz/fix/ui-element-maker-icon

fix(maker): Fix icon argument usage in UiElementMaker
monsieurbiz · Aug 26, 2024 · 4b44843 · 4b44843
2 parents ee199d3 + c4ce8a6
commit 4b44843
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/composer.json b/composer.json
@@ -29,7 +29,7 @@
             "assets:install %PUBLIC_DIR%": "symfony-cmd"
         },
         "phpcs": "PHP_CS_FIXER_IGNORE_ENV=1 php-cs-fixer fix --using-cache=no",
-        "phpstan": "phpstan analyse -c phpstan.neon src/",
+        "phpstan": "phpstan analyse -c phpstan.neon",
         "phpmd": "phpmd --exclude Migrations/* src/ ansi phpmd.xml",
         "phpunit": "phpunit",
         "phpspec": "phpspec run"

diff --git a/phpstan.neon b/phpstan.neon
@@ -1,7 +1,7 @@
 parameters:
     level: 8
     paths:
-        - %rootDir%/src/
+        - src/
 
     excludePaths:
         # Makes PHPStan crash

diff --git a/src/Maker/UiElementMaker.php b/src/Maker/UiElementMaker.php
@@ -39,7 +39,7 @@ public function configureCommand(Command $command, InputConfiguration $inputConf
     {
         $command
             ->addArgument('code', InputArgument::OPTIONAL, 'The code of the UI Element (e.g. <fg=yellow>my_ui_element</>)')
-            ->addArgument('icon', InputArgument::OPTIONAL, 'The semantic icon code for the UI Element (e.g. <fg=yellow>map pin</>)')
+            ->addArgument('icon', InputArgument::OPTIONAL, 'The semantic icon code for the UI Element (e.g. <fg=yellow>map pin</>)', 'square')
             ->addArgument('code_prefix', InputArgument::OPTIONAL, 'The code prefix for the UI Element (e.g. <fg=yellow>app</>)', 'app')
             ->setDescription('Creates a new UI Element FormType and templates')
         ;
@@ -48,6 +48,7 @@ public function configureCommand(Command $command, InputConfiguration $inputConf
     public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator): void
     {
         $code = $input->getArgument('code');
+        $icon = $input->getArgument('icon');
         $codePrefix = $input->getArgument('code_prefix');
         Assert::string($code);
         $name = Str::asCamelCase($code);
@@ -61,7 +62,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
             __DIR__ . '/../Resources/skeleton/UiElementFormType.tpl.php',
             [
                 'code' => \sprintf('%s.%s', $codePrefix, $code),
-                'icon' => 'map pin',
+                'icon' => $icon,
                 'tags' => json_encode([]),
             ]
         );