Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to use FastHPOCR instead of exact string matching. Refa… #116

Merged
merged 1 commit into from
May 21, 2024

Conversation

tudorgroza
Copy link
Collaborator

…ctored HPOConceptRecognizer inheritance. Added data and tests.

…ctored HPOConceptRecognizer inheritance. Added data and tests.
@tudorgroza tudorgroza requested review from pnrobinson and ielis May 20, 2024 12:27
Copy link
Member

@pnrobinson pnrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, this is crashing on my end -- it is not finding the module:
ImportError while importing test module '/Users/robin/GIT/pyphetools/test/test_vital_status.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/importlib/init.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
test/test_vital_status.py:2: in
from pyphetools.creation import AgeOfDeathColumnMapper, Individual, MetaData
src/pyphetools/init.py:2: in
from . import creation
src/pyphetools/creation/init.py:10: in
from .create_template import TemplateCreator
src/pyphetools/creation/create_template.py:4: in
from .hpo_parser import HpoParser
src/pyphetools/creation/hpo_parser.py:8: in
from .hpo_fasthpocr_cr import HpoFastHPOCRConceptRecognizer
src/pyphetools/creation/hpo_fasthpocr_cr.py:3: in
from FastHPOCR.HPOAnnotator import HPOAnnotator
E ModuleNotFoundError: No module named 'FastHPOCR'
________________ ERROR collecting test/test_vital_status.py _________________
ImportError while importing test module '/Users/robin/GIT/pyphetools/test/test_vital_status.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/importlib/init.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
test/test_vital_status.py:2: in
from pyphetools.creation import AgeOfDeathColumnMapper, Individual, MetaData
src/pyphetools/init.py:2: in
from . import creation
src/pyphetools/creation/init.py:10: in
from .create_template import TemplateCreator
src/pyphetools/creation/create_template.py:4: in
from .hpo_parser import HpoParser
src/pyphetools/creation/hpo_parser.py:8: in
from .hpo_fasthpocr_cr import HpoFastHPOCRConceptRecognizer
src/pyphetools/creation/hpo_fasthpocr_cr.py:3: in
from FastHPOCR.HPOAnnotator import HPOAnnotator
E ModuleNotFoundError: No module named 'FastHPOCR'
========================== short test summary info ==========================
ERROR src/pyphetools/init.py
ERROR src/pyphetools/creation/init.py
ERROR src/pyphetools/creation/create_template.py
ERROR src/pyphetools/creation/disease_id_column_mapper.py
ERROR src/pyphetools/creation/hpo_fasthpocr_cr.py
ERROR src/pyphetools/creation/hpo_parser.py
ERROR src/pyphetools/creation/import_template.py
ERROR src/pyphetools/creation/option_column_mapper.py
ERROR src/pyphetools/creation/scm_generator.py
ERROR src/pyphetools/creation/structural_variant.py
ERROR src/pyphetools/creation/thresholded_column_mapper.py

@tudorgroza
Copy link
Collaborator Author

Did you install the module?

@pnrobinson
Copy link
Member

sorry it was very early in the morning, all is ok. Part of the CI is not building but that is not related to this PR so I will merge

@pnrobinson pnrobinson merged commit 9bf3b76 into develop May 21, 2024
3 of 4 checks passed
@pnrobinson pnrobinson deleted the feature/use-fasthpocr branch May 21, 2024 08:24
@tudorgroza
Copy link
Collaborator Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants