Subclass sync: Comments & minor refactor #736
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update: _convert_edge_namespace(): (i) removed unused optional param, (ii) improved documentation. - Update: Improved some comments explaining some confusingly named variables. - Update: Removed 'verbose' param from _get_direct_scr_rels(). This function ran fast, and there was no need to print out the time taken. - Update: Misc codestyle refactors - Update: Case 5 code: Was redundant with some other code. Made DRY.
joeflack4
added
enhancement
twhetzel
reviewed
Jan 9, 2025
| rels_mondo_mondo_all = set( # filter non-source parents | ||
| [x for x in rels_mondo_raw_all if any([x[2].startswith(y) for y in MONDO_PREFIX_MAP.keys()])]) | ||
| df5 = pd.DataFrame([{'subject_id': x[0], 'object_id': x[2]} for x in rels_mondo_mondo_all]) | ||
| df5 = pd.DataFrame([{'subject_id': x[0], 'object_id': x[2]} for x in rels_direct_mondo_mondo]) |
There was a problem hiding this comment.
@joeflack4 what change in the subclass data files does this make?
There was a problem hiding this comment.
Ah, that is what is mentioned in the OP, and I mentioned in passing at meeting possibly before the holidays:
One refactor here removes a redundant variable
rels_mondo_mondo_alland replaces it withrels_direct_mondo_mondo. I tested and confirmed these variables were equivalent.
So there are no changes in outputs.
|
@matentzn Your review on this as well whenever. Not time sensitive. Removes a duplicate variable. Outputs did not change at all, which can be seen in the mini build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
At first I was going to add some helpful comments, but I realized some refactoring could be done.
Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingeston this branch (afterdocker pull obolibrary/odkfull:dev), and no errors occurred?Build:
New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?
Additional info
One refactor here removes a redundant variable
rels_mondo_mondo_alland replaces it withrels_direct_mondo_mondo. I tested and confirmed these variables were equivalent.