Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Bug fixes: Synonym Sync - combined cases - build #730

Open
wants to merge 1 commit into
base: bugfix-syn-sync-combined
Choose a base branch
from

Conversation

joeflack4
Copy link
Contributor

@joeflack4
Copy link
Contributor Author

joeflack4 commented Dec 19, 2024

@twhetzel I will review tomorrow. I left Nico off review of this one; feel free to add him if that is preferable.

@joeflack4 joeflack4 self-assigned this Dec 19, 2024
@joeflack4 joeflack4 added the build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes label Dec 19, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These direct-source-indirect-mondo files are being added because that PR was merged recently, but they do not yet exist on develop. Expected~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy to see that this file was not deleted during this build! Which is what the PR is intended to fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also did not experience any "hanging" in the terminal with this build. So looks like that fix worked as well.

Copy link
Contributor Author

@joeflack4 joeflack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant