-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: Bug fixes: Synonym Sync - combined cases - build #730
base: bugfix-syn-sync-combined
Are you sure you want to change the base?
DO NOT MERGE: Bug fixes: Synonym Sync - combined cases - build #730
Conversation
@twhetzel I will review tomorrow. I left Nico off review of this one; feel free to add him if that is preferable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These direct-source-indirect-mondo
files are being added because that PR was merged recently, but they do not yet exist on develop
. Expected~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy to see that this file was not deleted during this build! Which is what the PR is intended to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also did not experience any "hanging" in the terminal with this build. So looks like that fix worked as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build for:
synonym_sync_combined_cases.robot.tsv
& build hangs #727