Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: make mui, emotion peer deps #40

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix!: make mui, emotion peer deps #40

merged 1 commit into from
Jan 22, 2025

Conversation

ChristopherChudzicki
Copy link
Collaborator

@ChristopherChudzicki ChristopherChudzicki commented Jan 21, 2025 •
edited
Loading

What are the relevant tickets?

A tweak for https://github.com/mitodl/hq/issues/6279

Description (What does it do?)

This PR:

  • makes mui peer dependencies instead of regular dep. Making a peer dependency removes possibility for multiple versions, which (A) bloats and (B) can be problematic for useContext.
  • deep merges theme opt into the defaults, for reason mentioned HERE

How can this be tested?

Test with this branch in MIT Learn:

Notes

This is a breaking change. (Though in practice, I'm not sure any of our repos will require an update to accomodate for this.)

@ChristopherChudzicki ChristopherChudzicki changed the title make mui, emotion peer deps fix!: make mui, emotion peer deps Jan 21, 2025
@ChristopherChudzicki ChristopherChudzicki mentioned this pull request Jan 21, 2025
Merged
1 task
@gumaerc gumaerc self-assigned this Jan 22, 2025
gumaerc
gumaerc approved these changes Jan 22, 2025
View reviewed changes
Copy link

@gumaerc gumaerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristopherChudzicki ChristopherChudzicki merged commit 3d69c17 into main Jan 22, 2025
9 of 11 checks passed
@ChristopherChudzicki
Copy link
Collaborator Author

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ChristopherChudzicki ChristopherChudzicki mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gumaerc gumaerc gumaerc approved these changes

Assignees

@gumaerc gumaerc

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristopherChudzicki @gumaerc