feat!: remove unstable variants #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
changed the title
ChristopherChudzicki
changed the title
gumaerc
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
👍
I checked the buttons that were using these variants in mitodl/mit-learn#1979 and they look fine with the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
None, but followup to #40 since that was a breaking change anyway.
Description (What does it do?)
Removes the
unstable_button variants, which were erroneously introduced in MIT Learn.How can this be tested?
Tests should pass; if you want,
yarn startand check out the Button page.Note: This branch is in use on mitodl/mit-learn#1979