-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: ChuyuTeam.DISM++ version 10.1.2000.0 #204566
Closed
ovsky
wants to merge
1
commit into
microsoft:master
from
ovsky:ChuyuTeam.DISM++-10.1.2000.0-78d59e53-bb0c-448e-83e9-ab4b0c926c5c
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
13 changes: 13 additions & 0 deletions
13
manifests/c/ChuyuTeam/DISM++/10.1.2000.0/ChuyuTeam.DISM++.installer.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Created using wingetcreate 1.9.3.0 | ||
| # yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.9.0.schema.json | ||
|
|
||
| PackageIdentifier: ChuyuTeam.DISM++ | ||
| PackageVersion: 10.1.2000.0 | ||
| InstallerType: portable | ||
| Installers: | ||
| - Architecture: x64 | ||
| InstallerUrl: https://github.com/ovsky/DISM--winget-package/releases/download/10.1.2000.0-x64-x86/DISM++.10.1.2000.0-x64-x86.exe | ||
| InstallerSha256: 10C52D8826B9A2CF59B8CE445B1438F357D1F207DB900058B02FD30E5934E608 | ||
| ManifestType: installer | ||
| ManifestVersion: 1.9.0 | ||
| ReleaseDate: 2025-01-01 | ||
15 changes: 15 additions & 0 deletions
15
manifests/c/ChuyuTeam/DISM++/10.1.2000.0/ChuyuTeam.DISM++.locale.en-US.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Created using wingetcreate 1.9.3.0 | ||
| # yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.9.0.schema.json | ||
|
|
||
| PackageIdentifier: ChuyuTeam.DISM++ | ||
| PackageVersion: 10.1.2000.0 | ||
| PackageLocale: en-US | ||
| Publisher: Chuyu Team | ||
| PublisherUrl: https://github.com/ovsky | ||
| PackageName: DISM++ | ||
| PackageUrl: https://github.com/ovsky/DISM--winget-package | ||
| License: MIT License | ||
| ShortDescription: DISM++ - Windows System Multi-Tool and Essential Utility | ||
| ReleaseNotesUrl: https://github.com/ovsky/DISM--winget-package/releases/tag/10.1.2000.0-x64-x86 | ||
| ManifestType: defaultLocale | ||
| ManifestVersion: 1.9.0 |
8 changes: 8 additions & 0 deletions
8
manifests/c/ChuyuTeam/DISM++/10.1.2000.0/ChuyuTeam.DISM++.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Created using wingetcreate 1.9.3.0 | ||
| # yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.9.0.schema.json | ||
|
|
||
| PackageIdentifier: ChuyuTeam.DISM++ | ||
| PackageVersion: 10.1.2000.0 | ||
| DefaultLocale: en-US | ||
| ManifestType: version | ||
| ManifestVersion: 1.9.0 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem like an official URL from the ChuyuTeam. Only official URLs are supported
https://github.com/Chuyu-Team/Dism-Multi-language
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's their official repository, with the latest builds.
They also shared it on the official team website:
https://chuyu.me/en-US/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Trenly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ovsky - I'm saying that the installer URL is pointing to your own repo and not the official one. In order for us to accept the package, it should be pointing to the official repository, not your own rehosting of the binary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Trenly okay, but their do not provide the installer. I previously tried to send the binary wit required files, but another WinGet mod - in previous PR - told me to pack it and upload an installer.
If not this way either, how can I put the DISM++ on the winget repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or do you mean that it is enough that the URL points to the correct repository and everything else is fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern is that then you have modified it, and it wouldn’t be the official Chuyu Team distribution still. You could call it
ovsky.DISM++, since then it isn't claiming to be a package officially provided by Chuyu TeamHowever, an installer should not technically be required. I looked at what is in the zip file, and it should be perfectly fine to specify it as -
If that doesn't work, then I'm not sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Trenly thank you very much for all your help and as well pushing DISM++ to winget repository by yourself! It will be really helpful for every person using it for debloating and adjusting Windows.